fix(Compiler): Fix a case where provider fields weren't type annotated

Closes #915.

PiperOrigin-RevId: 186834153

Author: leonsenft

_tests/test/core/change_detection/detect_host_changes_test.dart

@@ -57,8 +57,5 @@ class SomeDirective {
   String dataXyz = 'abc';
   bool disabled = true;
   void handleClick(Event e) {}
-
-  // TODO: Should be 'KeyEvent'.
-  // See https://github.com/dart-lang/angular/issues/915.
-  void handleKeyPress(Event e) {}
+  void handleKeyPress(KeyEvent e) {}
 }

angular/CHANGELOG.md

@@ -220,9 +220,12 @@ class Comp {
     D. Giving C local visibility incorrectly prevented this assignment and
     generated code to inject D from the parent injector.
 
-*  Fixed a bug where `Provider<List<T>>` was treated as `Provider<List>` when
-   compiled as part of the view compiler (`@Component.providers:`). Now the
-   additional generic types flow through the compiler.
+*   Fixed a bug where `Provider<List<T>>` was treated as `Provider<List>` when
+    compiled as part of the view compiler (`@Component.providers:`). Now the
+    additional generic types flow through the compiler.
+
+*   Fixed a case where provider fields weren't type annotated. In some cases
+    this led to DDC warnings that are to become errors.
 
 ## 5.0.0-alpha+5
 

angular/lib/src/compiler/view_compiler/compile_view.dart

@@ -871,14 +871,14 @@ class CompileView implements AppViewBuilder {
             )
           : o.DYNAMIC_TYPE);
     } else {
-      resolvedProviderValueExpr = providerValueExpressions[0];
+      resolvedProviderValueExpr = providerValueExpressions.first;
       if (provider.typeArgument != null) {
         type = o.importType(
           provider.typeArgument,
           provider.typeArgument.genericTypes,
         );
       } else {
-        type = providerValueExpressions[0].type;
+        type = resolvedProviderValueExpr.type;
       }
     }
 
@@ -986,7 +986,7 @@ class CompileView implements AppViewBuilder {
               ? o.DYNAMIC_TYPE
               : (providerHasChangeDetector ? changeDetectorType : type)));
     }
-    return new o.ReadClassMemberExpr(propName);
+    return new o.ReadClassMemberExpr(propName, type);
   }
 
   @override