DDC needs to stop skipping type build/runtime checks

[matanlurey]

As hit internally:

import 'package:angular/angular.dart';

const windowBindings = const [ ... ];

const tableBindings = const [
  windowBindings,
  const ClassProvider(OtherClass),
];

const tableModule = const Module(
  provide: tableBindings,
);

See the error? Well, Module.provide only takes a List<Provider>, but is being passed a List<Object> (or is it List<dynamic>?). This passes type-checking during build-time (and DDC runtime), but will fail in Dart2JS - and will fail otherwise in our actual framework code, because I assume every element is a Provider.

I think this is due to List currently being a white-listed "skip checks on me", thing. The CFE has no such concept, and Dart2JS with --preview-dart-2, will fail.

[matanlurey]

This is not related to DDC

[kevmoo]

This is not related to DDC

Huh? Different title?

[matanlurey]

Closing. This is actually dart-lang/sdk#33304.