refactor(typefusion): effect errors are already yieldable, don't need to wrap them with effect.fail

Author: aniravi24

packages/typefusion/src/db/clickhouse/types.ts

@@ -101,12 +101,10 @@ export const valueToClickhouseType = (
       case "boolean":
         return "Bool";
       default:
-        return yield* Effect.fail(
-          new UnsupportedJSTypeDbConversionError({
-            cause: null,
-            message: `Unsupported JS type in Clickhouse for provided value: ${typeof value}`,
-          }),
-        );
+        return yield* new UnsupportedJSTypeDbConversionError({
+          cause: null,
+          message: `Unsupported JS type in Clickhouse for provided value: ${typeof value}`,
+        });
     }
   });
 

packages/typefusion/src/db/mysql/types.ts

@@ -84,12 +84,10 @@ export const valueToMySqlType = (
       case "boolean":
         return "BOOLEAN";
       default:
-        return yield* Effect.fail(
-          new UnsupportedJSTypeDbConversionError({
-            cause: null,
-            message: `Unsupported JS type in mysql for provided value: ${typeof value}`,
-          }),
-        );
+        return yield* new UnsupportedJSTypeDbConversionError({
+          cause: null,
+          message: `Unsupported JS type in mysql for provided value: ${typeof value}`,
+        });
     }
   });
 

packages/typefusion/src/db/postgres/types.ts

@@ -104,12 +104,10 @@ export const valueToPostgresType = (
       case "boolean":
         return "BOOLEAN";
       default:
-        return yield* Effect.fail(
-          new UnsupportedJSTypeDbConversionError({
-            cause: null,
-            message: `Unsupported JS type in postgres for provided value: ${typeof value}`,
-          }),
-        );
+        return yield* new UnsupportedJSTypeDbConversionError({
+          cause: null,
+          message: `Unsupported JS type in postgres for provided value: ${typeof value}`,
+        });
     }
   });
 

packages/typefusion/src/store.ts

@@ -284,12 +284,10 @@ const convertTypefusionScriptResultToSQLDDL = (
     // If no database types are provided, we will infer them from the result data
     if (!module.schema || Object.keys(module.schema).length === 0) {
       if (result.data.length === 0) {
-        yield* Effect.fail(
-          new ConvertDataToSQLDDLError({
-            cause: null,
-            message: `Your data for script '${module.name}' is empty, please add types for module '${module.name}'. We can't infer the database types from an empty result.`,
-          }),
-        );
+        yield* new ConvertDataToSQLDDLError({
+          cause: null,
+          message: `Your data for script '${module.name}' is empty, please add types for module '${module.name}'. We can't infer the database types from an empty result.`,
+        });
       }
       yield* Effect.logDebug(
         `No database types provided for module '${module.name}', inferring from first item in result data.`,
@@ -383,26 +381,22 @@ export const dbInsert = (module: TypefusionScriptExport, result: unknown) =>
     } else {
       if (!resultIsValidSchema) {
         yield* Effect.logError("Invalid script run result: ", result);
-        yield* Effect.fail(
-          new DatabaseInsertError({
-            cause: null,
-            message: `Module '${module.name}' does not match expected schema, make sure your run function returns an object with the following shape: ${ScriptResultSchema.toString()}`,
-          }),
-        );
+        yield* new DatabaseInsertError({
+          cause: null,
+          message: `Module '${module.name}' does not match expected schema, make sure your run function returns an object with the following shape: ${ScriptResultSchema.toString()}`,
+        });
       }
       if (!moduleIsValidSchema) {
         yield* Effect.logError(
           "Invalid module export: ",
           // We are going to assume that people at least provided a name
           (module as TypefusionScriptExport).name,
         );
-        yield* Effect.fail(
-          new DatabaseInsertError({
-            cause: null,
-            // We are going to assume that people at least provided a name
-            message: `Module '${(module as TypefusionScriptExport).name}' does not match expected schema, make sure your script returns an object with the following shape: ${ScriptExportSchema.toString()}`,
-          }),
-        );
+        yield* new DatabaseInsertError({
+          cause: null,
+          // We are going to assume that people at least provided a name
+          message: `Module '${(module as TypefusionScriptExport).name}' does not match expected schema, make sure your script returns an object with the following shape: ${ScriptExportSchema.toString()}`,
+        });
       }
     }
   });