Skip to content

Commit 49c9891

Browse files
kriyanshiians9868
authored andcommitted
[Data] Fix Task Completion Time Without Backpressure Grafana panel metric name (ray-project#60481)
## Description Fixes the broken **"Task Completion Time Without Backpressure"** metrics chart in the Ray Data Grafana dashboard. The panel was querying `ray_data_task_completion_time_without_backpressure`, which no longer exists. PR ray-project#57788 renamed the underlying metric to `task_completion_time_excl_backpressure_s` in `op_runtime_metrics.py`, but the Grafana panel in `data_dashboard_panels.py` was not updated. This PR updates the panel's Prometheus `expr` to use `ray_data_task_completion_time_excl_backpressure_s` so the chart displays data again. **Change:** Single-line fix in `data_dashboard_panels.py` — replace the old metric name with the correct one in the panel's `expr`. The formula (average task completion time excluding backpressure over a 5-minute window) is unchanged. ## Related issues Fixes the regression from ray-project#57788 (metric rename). Related to Ray Data monitoring / dashboard. Closes: ray-project#60163 ## Additional information - **Metric flow:** `op_runtime_metrics.task_completion_time_excl_backpressure_s` → Stats uses `data_{name}` → Metrics agent adds `ray_` namespace → **`ray_data_task_completion_time_excl_backpressure_s`** - **Manual verification:** Run a Ray Data job with Grafana + Prometheus (see [cluster metrics](https://docs.ray.io/en/latest/cluster/metrics.html)), then confirm the "Task Completion Time Without Backpressure" panel shows data. Signed-off-by: kriyanshii <kriyanshishah06@gmail.com> Signed-off-by: Adel Nour <ans9868@nyu.edu>
1 parent 34f1644 commit 49c9891

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

python/ray/dashboard/modules/metrics/dashboards/data_dashboard_panels.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,7 @@
684684
unit="s",
685685
targets=[
686686
Target(
687-
expr='increase(ray_data_task_completion_time_without_backpressure{{{global_filters}, operator=~"$Operator"}}[5m]) / increase(ray_data_num_tasks_finished{{{global_filters}, operator=~"$Operator"}}[5m])',
687+
expr='increase(ray_data_task_completion_time_excl_backpressure_s{{{global_filters}, operator=~"$Operator"}}[5m]) / increase(ray_data_num_tasks_finished{{{global_filters}, operator=~"$Operator"}}[5m])',
688688
legend="Task Completion Time w/o Backpressure: {{dataset}}, {{operator}}",
689689
),
690690
],

0 commit comments

Comments
 (0)