Skip to content

Commit 97037a9

Browse files
PipKatakaszynski
andauthored
Add branch naming conventions link to Contributing (#31)
* Add link to "Branch Naming Conventions" section in dev_practives.rst * Update doc/source/overview/contributing.rst Co-authored-by: Alex Kaszynski <[email protected]> Co-authored-by: Alex Kaszynski <[email protected]>
1 parent bc97e4c commit 97037a9

File tree

2 files changed

+32
-14
lines changed

2 files changed

+32
-14
lines changed

doc/source/guidelines/dev_practices.rst

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ If your PR branch is a ``fix/`` branch, do not delete it because it may be neces
6464
merge your PR branch with the current release branch. See the next section for branch
6565
naming conventions.
6666

67+
.. _branch_naming:
68+
6769
Branch Naming Conventions
6870
~~~~~~~~~~~~~~~~~~~~~~~~~
6971
To streamline development, we have the following requirements for naming
@@ -154,9 +156,9 @@ Documentation Style and Organization
154156
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
155157
Docstrings should follow `numpydocs docstring <https://numpydoc.readthedocs.io/en/latest/format.html>`_
156158
guidelines. Documentation within the ``doc/`` directory use the reStructuredText.
157-
(RST) format. Examples within the ``examples/`` directory should be PEP8-compliant
159+
(RST) format. Examples within the ``examples/`` directory should be PEP 8-compliant
158160
and will be compiled dynamically during the build process. Always ensure that
159-
examples run properly locally as they will be verified through the CI performed
161+
examples run properly locally because they will be verified through the CI performed
160162
via GitHub Actions.
161163

162164
Documentation for the latest stable release of a PyAnsys libary is accessible

doc/source/overview/contributing.rst

Lines changed: 28 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,23 @@ library's documentation, including:
1818
- Instructions for cloning the source repository from GitHub
1919
- URL to the library's ``Issues`` page
2020

21+
Creating Issues
22+
---------------
23+
You create issues to submit questions, report bugs, and request new
24+
features. When you create an issue, ensure that you provide sufficient
25+
context, such as application versions and reproduction steps. Also use
26+
an issue label like "Documentation" to indicate the issue category.
27+
28+
PyAnsys developers and community members will respond to and hopefully
29+
resolve your issue. Once an issue is resolved, you are encouraged to
30+
close it yourself. Otherwise, after a period of inactivity, the PyAnsys
31+
project support team will use discretion as to whether to close it.
32+
33+
Should it turn out that your issue is closed erroneously, perhaps because
34+
a bug fix implemented to resolve your issue did not work, you can re-open
35+
it with a comment that explains why you have done so. If you need to contact the
36+
PyAnsys project support team directly, email `[email protected] <[email protected]>`_.
37+
2138
For convenience, here are URLs for ``Issues`` pages for
2239
Ansys product repositories:
2340

@@ -27,19 +44,16 @@ Ansys product repositories:
2744
- `PyMAPDL Issues <https://github.com/pyansys/pymapdl/issues>`_
2845
- `PyMAPDL-Reader Issues <https://github.com/pyansys/pymapdl-reader/issues>`_
2946

30-
You can reach the overall PyAnsys project support team at
31-
32-
3347
Submitting Questions
34-
---------------------
48+
~~~~~~~~~~~~~~~~~~~~
3549
For general or technical questions about a PyAnsys library, its
3650
applications, or software usage, create issues on the respective
3751
library's ``Issues`` page. This allows PyAnsys developers and
3852
community members with the needed expertise to collectively address
3953
them. It also makes their responses available to all users.
4054

4155
Reporting Bugs
42-
--------------
56+
~~~~~~~~~~~~~~
4357
If you encounter a bug or your workflow crashes while using a
4458
PyAnsys library, create an issue on the respective library's
4559
``Issues`` page and tag it with an appropriate label so that it
@@ -49,7 +63,7 @@ provide a traceback, screenshots, and sample files that might help
4963
the community to address the issue.
5064

5165
Requesting New Features
52-
-----------------------
66+
~~~~~~~~~~~~~~~~~~~~~~~
5367
We encourage you to submit ideas for improving PyAnsys libraries.
5468
To suggest a new feature, create an issue on the respective library's
5569
``Issues`` page and tag it with the ``Feature Request`` label. Use a
@@ -79,14 +93,14 @@ practice, you would create a discussion on this library's `Discussions <https://
7993
page. It is possible for discussions to lead to the creation of issues.
8094

8195
.. note::
82-
Because the ``Discussions`` feature is still in beta on GitHub, usage may
83-
change in the future.
96+
Because the ``Discussions`` page is still a beta feature on GitHub, usage
97+
may change in the future.
8498

8599
Cloning the Source Repository
86100
-----------------------------
87101
As mentioned earlier, specific instructions for cloning a source
88102
repository from GitHub appear on the ``Contributing`` page in the
89-
respective library's documentation. In te following code for cloning and
103+
respective library's documentation. In the following code for cloning and
90104
installing the latest version of a PyAnsys repository, ``<pyansy-repository>``
91105
is a placeholder for the name of the repository.
92106

@@ -96,8 +110,8 @@ is a placeholder for the name of the repository.
96110
cd <pyansys-repository>
97111
pip install -e .
98112
99-
For example, you would use this code to clone and installing the latest version
100-
of PyMAPDL:
113+
For example, to clone and install the latest version of PyMAPDL,
114+
you would run the following:
101115

102116
.. code::
103117
@@ -107,7 +121,9 @@ of PyMAPDL:
107121
108122
If you want to eventually push a contribution to the official
109123
PyAnsys repository, consider creating a `fork <https://docs.github.com/en/get-started/quickstart/fork-a-repo>`_
110-
of the repository. For additional information, see :ref: dev_practices.
124+
of the repository. For information on how to contribute through
125+
GitHub, see :ref:`development_practices`, paying particular attention to :ref:`branch_naming`
126+
when you are ready to create a pull request.
111127

112128
Licensing
113129
---------

0 commit comments

Comments
 (0)