Skip to content

PowerShellEditorServices is v1.10.1 (6 years old) #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MostHated opened this issue Mar 1, 2024 · 4 comments
Closed

PowerShellEditorServices is v1.10.1 (6 years old) #188

MostHated opened this issue Mar 1, 2024 · 4 comments
Labels
infra Tasks about build, CI and other project infrastructure

Comments

@MostHated
Copy link

MostHated commented Mar 1, 2024

I have noticed that this plugin itself receives relatively regular updates (looks like once a month at least for the last few months), but not the bundled packages. The PowerShellEditorServices package included has a release date from v1.10.1: Dec 2018. The current version is v3.17.0: Jan 2024.

You will have to forgive me, as I am not very familiar (at all) with Jetbrains plugins or what they require when integrating an external language/service, but I was wondering if there was a specific reason for this (Ex. Does the PSES library require modification, or there are compatibility issues?) or just no one has got around to it?
I am guessing that it must not be as simple as swapping out the old library and replacing it with the new version?

Thanks,
-MH

@ForNeVeR ForNeVeR added help wanted Extra attention is needed infra Tasks about build, CI and other project infrastructure labels Mar 1, 2024
@ForNeVeR
Copy link
Collaborator

ForNeVeR commented Mar 1, 2024

There is a specific reason for this, but it's not that deep.

Update of anything bundled is currently pretty messy: you have to update a lot of bundled source files and sometimes even binaries, and this doesn't feel right.

I have a task to update PSScriptAnalyzer in my backlog (#109), and maybe will tackle PSES next (hopefully that will be easier after I get some dependency system in place of what we currently have instead).

Thanks for your report.

@ForNeVeR
Copy link
Collaborator

ForNeVeR commented Mar 1, 2024

Ah, actually, this has already been requested, and I even tried that, and it failed (see the comments) :(

See #51. I'm closing this request as a duplicate.

It is still in my backlog after #109.

@ForNeVeR ForNeVeR closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
@ForNeVeR ForNeVeR removed the help wanted Extra attention is needed label Mar 1, 2024
@MostHated
Copy link
Author

I understand.

The main reason I bring it up, is that overall functionality on my end is broken (presumably because of the age of the library) when using relatively recent functionality.

Example Code in Rider

Example Code in VSCode

The same code is recognized as valid in both VSCode with the powershell plugin, as well as neovim when using an updated version PowerShellEditorServices (as seen by the reference count, lack of error, etc in the second image).
In Rider, everything below the enum declaration is broken, unfortunately, making it unusable for code that uses newer features.

@ForNeVeR
Copy link
Collaborator

ForNeVeR commented Mar 4, 2024

Note that highlighting in the plugin doesn't use PSES, so it is unlikely to be broken because of that. We have quite a few issues with certain modern (and often old as well) snippets and language features not being properly recognized, this all is in my current backlog as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Tasks about build, CI and other project infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants