-
Notifications
You must be signed in to change notification settings - Fork 15
[1.2.0] P2P: BP gossip connections #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -489,6 +489,17 @@ class bp_connection_manager { | |||
return addresses; | |||
} | |||
|
|||
flat_set<std::string> all_gossip_bp_addresses(const char* desc) const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that boost::unordered_flat_set
would be better here and for find_gossip_bp_addresses
unless there is a reason to use boost::flat_set
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the test fails because it is not ordered... maybe you can convert to a std::set
for the comparison?
@@ -174,6 +174,7 @@ BOOST_AUTO_TEST_CASE(test_on_pending_schedule) { | |||
plugin.lib_catchup = true; | |||
plugin.on_pending_schedule(test_schedule1); | |||
|
|||
std::ranges::sort(connected_hosts); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think this one is needed if we expect the vector to be empty
Resolves #1584