feat: upgrade eslint-plugin-react-hooks to v7 (#764)

Jungzl · web-flow · commit b7653503f0eb · 2025-10-15T11:24:52.000+09:00
diff --git a/fixtures/input/jsx.jsx b/fixtures/input/jsx.jsx
@@ -1,17 +1,17 @@
+import React from 'react';
 export function HelloWorld({
   greeting = "hello", greeted = '"World"', silent = false, onMouseOver,}) {
 
+  const [num] = React.useState(()=>    Math
+      .floor (Math.random() * 1E+7).toString()
+        .replace(/\.\d+/ig, ""))
+
   if(!greeting){
     return null};
 
-      // TODO: Don't use random in render
-  let num = Math
-  .floor (Math.random() * 1E+7).toString()
-    .replace(/\.\d+/ig, "")
-
   return <div className='HelloWorld' title={`You are visitor number ${ num }`} onMouseOver={onMouseOver}>
     <strong>{ greeting.slice( 0, 1 ).toUpperCase() + greeting.slice(1).toLowerCase() }</strong>
-    {greeting.endsWith(",") 
+    {greeting.endsWith(",")
     ? " " : <span style={{color: '\grey'}}>", "</span> }
     <em>
   { greeted }
diff --git a/fixtures/output/all/jsx.jsx b/fixtures/output/all/jsx.jsx
@@ -1,19 +1,20 @@
+import React from 'react'
+
 export function HelloWorld({
   greeting = 'hello',
   greeted = '"World"',
   silent = false,
   onMouseOver,
 }) {
+  const [num] = React.useState(() => Math
+    .floor (Math.random() * 1e+7)
+    .toString()
+    .replace(/\.\d+/g, ''))
+
   if (!greeting) {
     return null
   };
 
-  // TODO: Don't use random in render
-  const num = Math
-    .floor (Math.random() * 1e+7)
-    .toString()
-    .replace(/\.\d+/g, '')
-
   return (
     <div className="HelloWorld" title={`You are visitor number ${num}`} onMouseOver={onMouseOver}>
       <strong>{ greeting.slice(0, 1).toUpperCase() + greeting.slice(1).toLowerCase() }</strong>
diff --git a/fixtures/output/js/jsx.jsx b/fixtures/output/js/jsx.jsx
@@ -1,19 +1,20 @@
+import React from 'react'
+
 export function HelloWorld({
   greeting = 'hello',
   greeted = '"World"',
   silent = false,
   onMouseOver,
 }) {
+  const [num] = React.useState(() => Math
+    .floor (Math.random() * 1e+7)
+    .toString()
+    .replace(/\.\d+/g, ''))
+
   if (!greeting) {
     return null
   };
 
-  // TODO: Don't use random in render
-  const num = Math
-    .floor (Math.random() * 1e+7)
-    .toString()
-    .replace(/\.\d+/g, '')
-
   return (
     <div className="HelloWorld" title={`You are visitor number ${num}`} onMouseOver={onMouseOver}>
       <strong>{ greeting.slice(0, 1).toUpperCase() + greeting.slice(1).toLowerCase() }</strong>
diff --git a/fixtures/output/no-style/jsx.jsx b/fixtures/output/no-style/jsx.jsx
@@ -1,17 +1,17 @@
+import React from 'react';
 export function HelloWorld({
   greeting = "hello", greeted = '"World"', silent = false, onMouseOver,}) {
 
+  const [num] = React.useState(()=>    Math
+      .floor (Math.random() * 1e+7).toString()
+        .replace(/\.\d+/g, ""))
+
   if(!greeting){
     return null};
 
-      // TODO: Don't use random in render
-  const num = Math
-  .floor (Math.random() * 1e+7).toString()
-    .replace(/\.\d+/g, "")
-
   return <div className='HelloWorld' title={`You are visitor number ${ num }`} onMouseOver={onMouseOver}>
     <strong>{ greeting.slice( 0, 1 ).toUpperCase() + greeting.slice(1).toLowerCase() }</strong>
-    {greeting.endsWith(",") 
+    {greeting.endsWith(",")
     ? " " : <span style={{color: '\grey'}}>", "</span> }
     <em>
   { greeted }
diff --git a/fixtures/output/tab-double-quotes/jsx.jsx b/fixtures/output/tab-double-quotes/jsx.jsx
@@ -1,19 +1,20 @@
+import React from "react"
+
 export function HelloWorld({
 	greeting = "hello",
 	greeted = "\"World\"",
 	silent = false,
 	onMouseOver,
 }) {
+	const [num] = React.useState(() => Math
+		.floor (Math.random() * 1e+7)
+		.toString()
+		.replace(/\.\d+/g, ""))
+
 	if (!greeting) {
 		return null
 	};
 
-	// TODO: Don't use random in render
-	const num = Math
-		.floor (Math.random() * 1e+7)
-		.toString()
-		.replace(/\.\d+/g, "")
-
 	return (
 		<div className="HelloWorld" title={`You are visitor number ${num}`} onMouseOver={onMouseOver}>
 			<strong>{ greeting.slice(0, 1).toUpperCase() + greeting.slice(1).toLowerCase() }</strong>
diff --git a/fixtures/output/ts-override/jsx.jsx b/fixtures/output/ts-override/jsx.jsx
@@ -1,19 +1,20 @@
+import React from 'react'
+
 export function HelloWorld({
   greeting = 'hello',
   greeted = '"World"',
   silent = false,
   onMouseOver,
 }) {
+  const [num] = React.useState(() => Math
+    .floor (Math.random() * 1e+7)
+    .toString()
+    .replace(/\.\d+/g, ''))
+
   if (!greeting) {
     return null
   };
 
-  // TODO: Don't use random in render
-  const num = Math
-    .floor (Math.random() * 1e+7)
-    .toString()
-    .replace(/\.\d+/g, '')
-
   return (
     <div className="HelloWorld" title={`You are visitor number ${num}`} onMouseOver={onMouseOver}>
       <strong>{ greeting.slice(0, 1).toUpperCase() + greeting.slice(1).toLowerCase() }</strong>
diff --git a/fixtures/output/ts-strict-with-react/jsx.jsx b/fixtures/output/ts-strict-with-react/jsx.jsx
@@ -1,19 +1,20 @@
+import React from 'react'
+
 export function HelloWorld({
   greeting = 'hello',
   greeted = '"World"',
   silent = false,
   onMouseOver,
 }) {
+  const [num] = React.useState(() => Math
+    .floor (Math.random() * 1e+7)
+    .toString()
+    .replace(/\.\d+/g, ''))
+
   if (!greeting) {
     return null
   };
 
-  // TODO: Don't use random in render
-  const num = Math
-    .floor (Math.random() * 1e+7)
-    .toString()
-    .replace(/\.\d+/g, '')
-
   return (
     <div className="HelloWorld" title={`You are visitor number ${num}`} onMouseOver={onMouseOver}>
       <strong>{ greeting.slice(0, 1).toUpperCase() + greeting.slice(1).toLowerCase() }</strong>
diff --git a/fixtures/output/ts-strict/jsx.jsx b/fixtures/output/ts-strict/jsx.jsx
@@ -1,19 +1,20 @@
+import React from 'react'
+
 export function HelloWorld({
   greeting = 'hello',
   greeted = '"World"',
   silent = false,
   onMouseOver,
 }) {
+  const [num] = React.useState(() => Math
+    .floor (Math.random() * 1e+7)
+    .toString()
+    .replace(/\.\d+/g, ''))
+
   if (!greeting) {
     return null
   };
 
-  // TODO: Don't use random in render
-  const num = Math
-    .floor (Math.random() * 1e+7)
-    .toString()
-    .replace(/\.\d+/g, '')
-
   return (
     <div className="HelloWorld" title={`You are visitor number ${num}`} onMouseOver={onMouseOver}>
       <strong>{ greeting.slice(0, 1).toUpperCase() + greeting.slice(1).toLowerCase() }</strong>
diff --git a/fixtures/output/with-formatters/jsx.jsx b/fixtures/output/with-formatters/jsx.jsx
@@ -1,19 +1,20 @@
+import React from 'react'
+
 export function HelloWorld({
   greeting = 'hello',
   greeted = '"World"',
   silent = false,
   onMouseOver,
 }) {
+  const [num] = React.useState(() => Math
+    .floor (Math.random() * 1e+7)
+    .toString()
+    .replace(/\.\d+/g, ''))
+
   if (!greeting) {
     return null
   };
 
-  // TODO: Don't use random in render
-  const num = Math
-    .floor (Math.random() * 1e+7)
-    .toString()
-    .replace(/\.\d+/g, '')
-
   return (
     <div className="HelloWorld" title={`You are visitor number ${num}`} onMouseOver={onMouseOver}>
       <strong>{ greeting.slice(0, 1).toUpperCase() + greeting.slice(1).toLowerCase() }</strong>
diff --git a/package.json b/package.json
@@ -52,7 +52,7 @@
     "eslint-plugin-astro": "^1.2.0",
     "eslint-plugin-format": ">=0.1.0",
     "eslint-plugin-jsx-a11y": ">=6.10.2",
-    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint-plugin-react-hooks": "^7.0.0",
     "eslint-plugin-react-refresh": "^0.4.19",
     "eslint-plugin-solid": "^0.14.3",
     "eslint-plugin-svelte": ">=2.35.1",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
diff --git a/src/cli/constants-generated.ts b/src/cli/constants-generated.ts
diff --git a/src/configs/react.ts b/src/configs/react.ts
diff --git a/test/fixtures.test.ts b/test/fixtures.test.ts
