cleanup: core: clean unused imports and remove redundant deps

- rm unused imports from various modules (audio/player, json/statuscache, ui/animation, ui/menu, ui/playerui, ui/ui).
- rm redundant dependencies: times from audio/player, asyncdispatch from ui/playerui
- rm scroll as an dependency and link since it is not used by menu.nim
- rm statuscache's variable fileInConsideration
- rm normalizeURL from jsonutils.nim

Author: antonl-dev

src/audio/player.nim

@@ -1,6 +1,6 @@
 # player.nim
 
-import libmpv, terminal, os
+import libmpv, os
 export cE  # Export the error-checking macro for external use
 
 type
@@ -164,7 +164,7 @@ proc getCurrentMediaTitle*(ctx: ptr Handle): string {.raises: [].} =
     if title != nil:
       libmpv.free(title)
 
-  except Exception as e:
+  except Exception: #as e:
     #raise newException(PlayerError, "Failed to get media title: " & e.msg)
     discard
 

src/json/statuscache.nim

@@ -1,7 +1,9 @@
 # statuscache.nim
 
 import
-  json, os, asyncdispatch, ../utils/utils, strutils, times, sequtils, terminal,
+  json, os, asyncdispatch,
+  ../utils/utils, strutils,
+  times, terminal,
 
   ../ui/stationstatus
 
@@ -102,7 +104,6 @@ proc saveStatusCacheToJson(stations; statuscontext) =
   fileInConsideration.close()
 
 proc readFromExistingStatusCache*(stations; statuscontext): JsonNode =
-  var fileInConsideration: File
   var filePathNameExt = statuscontext.sectionName
   getCacheJsonFileNameWithPath(filePathNameExt)
 

src/ui/animation.nim

@@ -1,6 +1,6 @@
 # animation.nim
 
-import times, terminal, ../utils/utils
+import terminal, ../utils/utils
 
 
 

src/ui/menu.nim

@@ -2,16 +2,10 @@
 
 import
   terminal, os, strutils, net,
-  json, tables, random,
+  random,
 
   ui, illwill,
 
-  ../audio/[
-      player,
-      libmpv,
-    ],
-
-  ../link/link,
   ../utils/[
     utils,
     jsonutils
@@ -20,13 +14,9 @@ import
   playerui
 
 when not defined(simple):
-  import asyncdispatch,
-
-    ../audio/metadata,
+  import
     ../ui/[
       stationstatus,
-      scroll,
-      animation,
      ],
     ../json/[
         statuscache

src/ui/playerui.nim

@@ -1,5 +1,5 @@
 import
-  terminal, os, strutils, net,
+  terminal, strutils, net,
   tables,
 
   ui, illwill,
@@ -15,8 +15,7 @@ import
   ]
 
 when not defined(simple):
-  import asyncdispatch,
-
+  import
     ../audio/metadata,
     ../ui/[
       scroll,

src/ui/ui.nim

@@ -11,7 +11,7 @@ import
   ]
 
 when not defined(simple):
-  import theme, stationstatus, scroll, animation
+  import stationstatus
 
 using str: string
 

src/utils/jsonutils.nim

@@ -3,8 +3,6 @@ import
 
   utilstypes
 
-from ../link/linkbase import normalizeUrl
-
 when defined(useJsmn):
   import ../json/jsmn
 else:

src/utils/privjsonstdlib.nim

@@ -1,9 +1,6 @@
 import json
 from ../link/linkbase import normalizeUrl
-import
-  os, strutils,
-
-  utilstypes
+import utilstypes
 
 proc loadStationStdLib*(filePath: string): tuple[names, urls: seq[string]] =
         let jsonData = parseJson(readFile(filePath))