Skip to content

Add some benchmarks #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dandandan opened this issue Jun 6, 2020 · 5 comments
Closed

Add some benchmarks #188

Dandandan opened this issue Jun 6, 2020 · 5 comments

Comments

@Dandandan
Copy link
Contributor

It would be nice to have some numbers on the performance of this parser. There are probably a few hotspots in the code, but without any numbers it is hard to find those.

We can maybe start with a few simple criterion benchmarks, like

created in forma/formation:
https://github.com/maxcountryman/forma/blob/master/formation/benches/formation_bench.rs

@nickolay
Copy link
Contributor

nickolay commented Jun 7, 2020

I'm in favor of adding something like this as a template to help with profiling, if we take care not to regress the build time for those not running the benchmarks.

But I don't see a problem with performance at this stage, and I don't think it should be a goal of this library to achieve the highest possible number of parses/second. For example, I'm going to trade being able to track position information (#161) for some performance.

@Dandandan
Copy link
Contributor Author

Yes, agree. However we probably can have the same functionality, while being faster, or track regressions a bit better.

@nickolay
Copy link
Contributor

nickolay commented Jun 7, 2020

Sure. Do you want to whip up a PR or should I mark this helpwanted?

@Dandandan
Copy link
Contributor Author

I probably make a PR soon!

@Dandandan
Copy link
Contributor Author

Fixed!

https://github.com/andygrove/sqlparser-rs/pull/190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants