Skip to content

CREATE DATABASE location #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyGost opened this issue Apr 4, 2022 · 2 comments
Open

CREATE DATABASE location #453

KyGost opened this issue Apr 4, 2022 · 2 comments

Comments

@KyGost
Copy link

KyGost commented Apr 4, 2022

#451 implemented support for CREATE DATABASE queries.
It includes two tests for the query.

Statement::CreateDatabase has two additional fields: location and managed_location. The syntax for these is not detailed; neither in the PR, nor anywhere else I can find.

  1. Perhaps this could be detailed in the docs
  2. Perhaps tests could be added for these fields
  3. What is the syntax for these fields?
@KyGost
Copy link
Author

KyGost commented Apr 4, 2022

Looking at the parser one can see that the syntax is:

CREATE DATABASE [database] LOCATION '[location]'

@AugustoFKL
Copy link
Contributor

@KyGost hey! I'm a new maintainer of SQL-parser (see #808), but I'd like to apologize for the huge delay. I'm catching up on old issues/PRs in my first three weeks, so I can start discussing/helping with syntax expansions again.

You're entirely correct. For your interest, I could find the PR that this was implemented (#235), and the syntax is from Hive SQL (check apache docs).

I'll add some comments regarding the syntax and the specificity of the syntax. Thanks for noting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants