add clippy lint to prevent from using std Instant

Signed-off-by: Ruihang Xia <[email protected]>

Author: waynexia

benchmarks/src/clickbench.rs

@@ -16,13 +16,14 @@
 // under the License.
 
 use std::path::Path;
-use std::{path::PathBuf, time::Instant};
+use std::path::PathBuf;
 
 use datafusion::{
     error::{DataFusionError, Result},
     prelude::SessionContext,
 };
 use datafusion_common::exec_datafusion_err;
+use datafusion_common::wasm::Instant;
 use structopt::StructOpt;
 
 use crate::{BenchmarkRun, CommonOpt};

benchmarks/src/parquet_filter.rs

@@ -24,8 +24,8 @@ use datafusion::logical_expr::{lit, or, Expr};
 use datafusion::physical_plan::collect;
 use datafusion::prelude::{col, SessionContext};
 use datafusion::test_util::parquet::{ParquetScanOptions, TestParquetFile};
+use datafusion_common::wasm::Instant;
 use std::path::PathBuf;
-use std::time::Instant;
 use structopt::StructOpt;
 
 /// Test performance of parquet filter pushdown

benchmarks/src/sort.rs

@@ -25,9 +25,9 @@ use datafusion::physical_plan::collect;
 use datafusion::physical_plan::sorts::sort::SortExec;
 use datafusion::prelude::{SessionConfig, SessionContext};
 use datafusion::test_util::parquet::TestParquetFile;
+use datafusion_common::wasm::Instant;
 use std::path::PathBuf;
 use std::sync::Arc;
-use std::time::Instant;
 use structopt::StructOpt;
 
 /// Test performance of sorting large datasets

benchmarks/src/tpch/convert.rs

@@ -15,9 +15,9 @@
 // specific language governing permissions and limitations
 // under the License.
 
+use datafusion_common::wasm::Instant;
 use std::fs;
 use std::path::{Path, PathBuf};
-use std::time::Instant;
 
 use datafusion::common::not_impl_err;
 use datafusion::error::DataFusionError;

benchmarks/src/tpch/run.rs

@@ -31,9 +31,9 @@ use datafusion::physical_plan::{collect, displayable};
 use datafusion_common::{DEFAULT_CSV_EXTENSION, DEFAULT_PARQUET_EXTENSION};
 use log::info;
 
+use datafusion_common::wasm::Instant;
 use std::path::PathBuf;
 use std::sync::Arc;
-use std::time::Instant;
 
 use datafusion::error::Result;
 use datafusion::prelude::*;

clippy.toml

@@ -2,3 +2,7 @@ disallowed-methods = [
     { path = "tokio::task::spawn", reason = "To provide cancel-safety, use `SpawnedTask::spawn` instead (https://github.com/apache/arrow-datafusion/issues/6513)" },
     { path = "tokio::task::spawn_blocking", reason = "To provide cancel-safety, use `SpawnedTask::spawn` instead (https://github.com/apache/arrow-datafusion/issues/6513)" },
 ]
+
+disallowed-types = [
+    { path = "std::time::Instant", reason = "Use `datafusion_common::instant::Instant` instead for WASM compatibility" },
+]

datafusion/common/src/wasm.rs

@@ -22,6 +22,7 @@
 /// under `wasm` feature gate. It provides the same API as [`std::time::Instant`].
 pub type Instant = instant::Instant;
 
+#[allow(clippy::disallowed_types)]
 #[cfg(not(target_family = "wasm"))]
 /// DataFusion wrapper around [`std::time::Instant`]. This is only a type alias.
 pub type Instant = std::time::Instant;