Skip to content

Commit e604477

Browse files
pjfanningclaude
andauthored
fix(license): add missing third-party attributions and ship LICENSE/NOTICE in Python wheels (#4127)
## Why? LICENSE is missing two third-party sources, and still ships a licence file nothing refers to. All three were found while verifying the 1.7.7-rc1 source release; see #4126. The Python wheels have a related gap: they ship with no LICENSE or NOTICE at all. ## What does this PR do? - **Fluent Python (MIT).** `record_class_factory` in `python/pyfory/type_util.py` is derived from `record_factory` in [fluentpython/example-code](https://github.com/fluentpython/example-code/blob/a7861802390010fc322f7fdbabf441ba36ed56f3/21-class-metaprog/factories.py). This PR: - adds an entry under "MIT licenses" in LICENSE; - adds the upstream MIT text as `licenses/LICENSE-fluentpython.txt`; - replaces the comment `# modified from 'fluent python'` with the upstream link and copyright notice, matching the existing `dataslots` attribution in the same file. - **Apache Spark.** `ClassLoaderUtils.java` (`ParentClassLoader`, `ChildFirstURLClassLoader`) is derived from Spark. This PR adds it to the spark entry in `LICENSE`, `java/LICENSE` and the fory-core jar's `META-INF/LICENSE`. - **Stale V8 licence.** This PR removes `licenses/LICENSE-v8.txt`. The vendored `v8-fast-api-calls.h` it covered, and its LICENSE entry, were removed in #2137. - **Protobuf comment.** This PR rewords the comment on `CPP_KEYWORDS` in `compiler/fory_compiler/generators/cpp.py`. It said the list was "Taken from kKeywordList … in protobuf". It is a list of C++ keywords, alternative operator tokens and the `NULL`/`assert` macros, not protobuf code. - **Python wheels have no LICENSE or NOTICE.** `python/pyproject.toml` declares `license = {file = "LICENSE"}`, but `python/LICENSE` doesn't exist and nothing in the build copies one in. setuptools only prints `File '.../LICENSE' cannot be found` and carries on. As a result, every published pyfory wheel ships with no LICENSE or NOTICE. I checked the manylinux and macOS wheels for 1.7.6, 1.0.0 and 0.13.0 on PyPI. This PR adds `python/LICENSE` and `python/NOTICE`, following the existing per-package files (`java/LICENSE`, `go/fory/LICENSE`, `dart/packages/fory/LICENSE`). They contain the Apache-2.0 text (identical to the root LICENSE) plus the third-party code the wheel actually contains: | Component | Licence | Where it ends up in the wheel | |---|---|---| | dataclasses | Apache-2.0 | `pyfory/type_util.py` (`dataslots`) | | Fluent Python example code | MIT (full text included) | `pyfory/type_util.py` (`record_class_factory`) | | abseil-cpp (`cpp/fory/thirdparty/flat_hash_map.h`) | Apache-2.0 | `serialization` extension | | smhasher (`cpp/fory/thirdparty/MurmurHash3.*`) | Public domain | `mmh3` and `serialization` extensions | I worked out the list from the Bazel targets for `//:cp_fory_so`. They link only Fory's own C++ plus those two vendored third-party files; there are no external C++ libraries. No build change is needed: setuptools adds `LICENSE*` and `NOTICE*` from the project directory to the wheel's `dist-info`. I checked this by running `BAZEL_BUILD_EXT=False python setup.py bdist_wheel` with setuptools 84.0.0 and 70.3.0 (the Python 3.8 range). Both wheels contain LICENSE and NOTICE, and METADATA lists them as `License-File` entries. There is no code change apart from comments. `ruff check` and `ruff format --check` give the same results on the changed Python files as on `main`. ## Related issues - Fixes #4126 ## Does this PR introduce any user-facing change? - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent d64cc8e commit e604477

9 files changed

Lines changed: 316 additions & 28 deletions

File tree

‎LICENSE‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ The text of each license is the standard Apache 2.0 license.
224224
* spark (https://github.com/apache/spark)
225225
Files:
226226
java/fory-core/src/main/java/org/apache/fory/codegen/Code.java
227+
java/fory-core/src/main/java/org/apache/fory/util/ClassLoaderUtils.java
227228
java/fory-format/src/main/java/org/apache/fory/format/vectorized/ArrowWriter.java
228229

229230
* commons-io (https://github.com/apache/commons-io)
@@ -323,6 +324,10 @@ The text of each license is also included in licenses/LICENSE-[project].txt
323324
Files:
324325
javascript/packages/core/lib/murmurHash3.ts
325326

327+
* fluentpython (https://github.com/fluentpython/example-code)
328+
Files:
329+
python/pyfory/type_util.py (record_class_factory function)
330+
326331

327332
================================================================
328333
Public Domain

‎compiler/fory_compiler/generators/cpp.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class CppGenerator(CppServiceGeneratorMixin, BaseGenerator):
8585
PrimitiveKind.FLOAT32,
8686
PrimitiveKind.FLOAT64,
8787
}
88-
# Taken from kKeywordList defined in helpers.cc in protobuf C++ compiler.
88+
# C++ keywords, alternative operator tokens, and the NULL and assert macros.
8989
CPP_KEYWORDS = {
9090
"NULL",
9191
"alignas",

‎java/LICENSE‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,7 @@ details. The text of each license is the standard Apache 2.0 license included ab
221221
* spark (https://github.com/apache/spark)
222222
Files:
223223
fory-core/src/main/java/org/apache/fory/codegen/Code.java
224+
fory-core/src/main/java/org/apache/fory/util/ClassLoaderUtils.java
224225
fory-format/src/main/java/org/apache/fory/format/vectorized/ArrowWriter.java
225226

226227
* commons-io (https://github.com/apache/commons-io)

‎java/fory-core/src/main/resources/META-INF/LICENSE‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ The text of each license is the standard Apache 2.0 license.
224224
* spark (https://github.com/apache/spark)
225225
Files:
226226
java/fory-core/src/main/java/org/apache/fory/codegen/Code.java
227+
java/fory-core/src/main/java/org/apache/fory/util/ClassLoaderUtils.java
227228

228229
* commons-io (https://github.com/apache/commons-io)
229230
Files:

‎licenses/LICENSE-fluentpython.txt‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
The MIT License (MIT)
2+
3+
Copyright (c) 2014 Luciano Ramalho
4+
5+
Permission is hereby granted, free of charge, to any person obtaining a copy
6+
of this software and associated documentation files (the "Software"), to deal
7+
in the Software without restriction, including without limitation the rights
8+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9+
copies of the Software, and to permit persons to whom the Software is
10+
furnished to do so, subject to the following conditions:
11+
12+
The above copyright notice and this permission notice shall be included in all
13+
copies or substantial portions of the Software.
14+
15+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21+
SOFTWARE.
22+

‎licenses/LICENSE-v8.txt‎

Lines changed: 0 additions & 26 deletions
This file was deleted.

‎python/LICENSE‎

Lines changed: 266 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,266 @@
1+
Apache License
2+
Version 2.0, January 2004
3+
http://www.apache.org/licenses/
4+
5+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
6+
7+
1. Definitions.
8+
9+
"License" shall mean the terms and conditions for use, reproduction,
10+
and distribution as defined by Sections 1 through 9 of this document.
11+
12+
"Licensor" shall mean the copyright owner or entity authorized by
13+
the copyright owner that is granting the License.
14+
15+
"Legal Entity" shall mean the union of the acting entity and all
16+
other entities that control, are controlled by, or are under common
17+
control with that entity. For the purposes of this definition,
18+
"control" means (i) the power, direct or indirect, to cause the
19+
direction or management of such entity, whether by contract or
20+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
21+
outstanding shares, or (iii) beneficial ownership of such entity.
22+
23+
"You" (or "Your") shall mean an individual or Legal Entity
24+
exercising permissions granted by this License.
25+
26+
"Source" form shall mean the preferred form for making modifications,
27+
including but not limited to software source code, documentation
28+
source, and configuration files.
29+
30+
"Object" form shall mean any form resulting from mechanical
31+
transformation or translation of a Source form, including but
32+
not limited to compiled object code, generated documentation,
33+
and conversions to other media types.
34+
35+
"Work" shall mean the work of authorship, whether in Source or
36+
Object form, made available under the License, as indicated by a
37+
copyright notice that is included in or attached to the work
38+
(an example is provided in the Appendix below).
39+
40+
"Derivative Works" shall mean any work, whether in Source or Object
41+
form, that is based on (or derived from) the Work and for which the
42+
editorial revisions, annotations, elaborations, or other modifications
43+
represent, as a whole, an original work of authorship. For the purposes
44+
of this License, Derivative Works shall not include works that remain
45+
separable from, or merely link (or bind by name) to the interfaces of,
46+
the Work and Derivative Works thereof.
47+
48+
"Contribution" shall mean any work of authorship, including
49+
the original version of the Work and any modifications or additions
50+
to that Work or Derivative Works thereof, that is intentionally
51+
submitted to Licensor for inclusion in the Work by the copyright owner
52+
or by an individual or Legal Entity authorized to submit on behalf of
53+
the copyright owner. For the purposes of this definition, "submitted"
54+
means any form of electronic, verbal, or written communication sent
55+
to the Licensor or its representatives, including but not limited to
56+
communication on electronic mailing lists, source code control systems,
57+
and issue tracking systems that are managed by, or on behalf of, the
58+
Licensor for the purpose of discussing and improving the Work, but
59+
excluding communication that is conspicuously marked or otherwise
60+
designated in writing by the copyright owner as "Not a Contribution."
61+
62+
"Contributor" shall mean Licensor and any individual or Legal Entity
63+
on behalf of whom a Contribution has been received by Licensor and
64+
subsequently incorporated within the Work.
65+
66+
2. Grant of Copyright License. Subject to the terms and conditions of
67+
this License, each Contributor hereby grants to You a perpetual,
68+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
69+
copyright license to reproduce, prepare Derivative Works of,
70+
publicly display, publicly perform, sublicense, and distribute the
71+
Work and such Derivative Works in Source or Object form.
72+
73+
3. Grant of Patent License. Subject to the terms and conditions of
74+
this License, each Contributor hereby grants to You a perpetual,
75+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
76+
(except as stated in this section) patent license to make, have made,
77+
use, offer to sell, sell, import, and otherwise transfer the Work,
78+
where such license applies only to those patent claims licensable
79+
by such Contributor that are necessarily infringed by their
80+
Contribution(s) alone or by combination of their Contribution(s)
81+
with the Work to which such Contribution(s) was submitted. If You
82+
institute patent litigation against any entity (including a
83+
cross-claim or counterclaim in a lawsuit) alleging that the Work
84+
or a Contribution incorporated within the Work constitutes direct
85+
or contributory patent infringement, then any patent licenses
86+
granted to You under this License for that Work shall terminate
87+
as of the date such litigation is filed.
88+
89+
4. Redistribution. You may reproduce and distribute copies of the
90+
Work or Derivative Works thereof in any medium, with or without
91+
modifications, and in Source or Object form, provided that You
92+
meet the following conditions:
93+
94+
(a) You must give any other recipients of the Work or
95+
Derivative Works a copy of this License; and
96+
97+
(b) You must cause any modified files to carry prominent notices
98+
stating that You changed the files; and
99+
100+
(c) You must retain, in the Source form of any Derivative Works
101+
that You distribute, all copyright, patent, trademark, and
102+
attribution notices from the Source form of the Work,
103+
excluding those notices that do not pertain to any part of
104+
the Derivative Works; and
105+
106+
(d) If the Work includes a "NOTICE" text file as part of its
107+
distribution, then any Derivative Works that You distribute must
108+
include a readable copy of the attribution notices contained
109+
within such NOTICE file, excluding those notices that do not
110+
pertain to any part of the Derivative Works, in at least one
111+
of the following places: within a NOTICE text file distributed
112+
as part of the Derivative Works; within the Source form or
113+
documentation, if provided along with the Derivative Works; or,
114+
within a display generated by the Derivative Works, if and
115+
wherever such third-party notices normally appear. The contents
116+
of the NOTICE file are for informational purposes only and
117+
do not modify the License. You may add Your own attribution
118+
notices within Derivative Works that You distribute, alongside
119+
or as an addendum to the NOTICE text from the Work, provided
120+
that such additional attribution notices cannot be construed
121+
as modifying the License.
122+
123+
You may add Your own copyright statement to Your modifications and
124+
may provide additional or different license terms and conditions
125+
for use, reproduction, or distribution of Your modifications, or
126+
for any such Derivative Works as a whole, provided Your use,
127+
reproduction, and distribution of the Work otherwise complies with
128+
the conditions stated in this License.
129+
130+
5. Submission of Contributions. Unless You explicitly state otherwise,
131+
any Contribution intentionally submitted for inclusion in the Work
132+
by You to the Licensor shall be under the terms and conditions of
133+
this License, without any additional terms or conditions.
134+
Notwithstanding the above, nothing herein shall supersede or modify
135+
the terms of any separate license agreement you may have executed
136+
with Licensor regarding such Contributions.
137+
138+
6. Trademarks. This License does not grant permission to use the trade
139+
names, trademarks, service marks, or product names of the Licensor,
140+
except as required for reasonable and customary use in describing the
141+
origin of the Work and reproducing the content of the NOTICE file.
142+
143+
7. Disclaimer of Warranty. Unless required by applicable law or
144+
agreed to in writing, Licensor provides the Work (and each
145+
Contributor provides its Contributions) on an "AS IS" BASIS,
146+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
147+
implied, including, without limitation, any warranties or conditions
148+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
149+
PARTICULAR PURPOSE. You are solely responsible for determining the
150+
appropriateness of using or redistributing the Work and assume any
151+
risks associated with Your exercise of permissions under this License.
152+
153+
8. Limitation of Liability. In no event and under no legal theory,
154+
whether in tort (including negligence), contract, or otherwise,
155+
unless required by applicable law (such as deliberate and grossly
156+
negligent acts) or agreed to in writing, shall any Contributor be
157+
liable to You for damages, including any direct, indirect, special,
158+
incidental, or consequential damages of any character arising as a
159+
result of this License or out of the use or inability to use the
160+
Work (including but not limited to damages for loss of goodwill,
161+
work stoppage, computer failure or malfunction, or any and all
162+
other commercial damages or losses), even if such Contributor
163+
has been advised of the possibility of such damages.
164+
165+
9. Accepting Warranty or Additional Liability. While redistributing
166+
the Work or Derivative Works thereof, You may choose to offer,
167+
and charge a fee for, acceptance of support, warranty, indemnity,
168+
or other liability obligations and/or rights consistent with this
169+
License. However, in accepting such obligations, You may act only
170+
on Your own behalf and on Your sole responsibility, not on behalf
171+
of any other Contributor, and only if You agree to indemnify,
172+
defend, and hold each Contributor harmless for any liability
173+
incurred by, or claims asserted against, such Contributor by reason
174+
of your accepting any such warranty or additional liability.
175+
176+
END OF TERMS AND CONDITIONS
177+
178+
APPENDIX: How to apply the Apache License to your work.
179+
180+
To apply the Apache License to your work, attach the following
181+
boilerplate notice, with the fields enclosed by brackets "[]"
182+
replaced with your own identifying information. (Don't include
183+
the brackets!) The text should be enclosed in the appropriate
184+
comment syntax for the file format. We also recommend that a
185+
file or class name and description of purpose be included on the
186+
same "printed page" as the copyright notice for easier
187+
identification within third-party archives.
188+
189+
Copyright [yyyy] [name of copyright owner]
190+
191+
Licensed under the Apache License, Version 2.0 (the "License");
192+
you may not use this file except in compliance with the License.
193+
You may obtain a copy of the License at
194+
195+
http://www.apache.org/licenses/LICENSE-2.0
196+
197+
Unless required by applicable law or agreed to in writing, software
198+
distributed under the License is distributed on an "AS IS" BASIS,
199+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
200+
See the License for the specific language governing permissions and
201+
limitations under the License.
202+
203+
This product bundles code with separate copyright notices and license terms.
204+
Your use of that code is subject to the terms and conditions of the following
205+
licenses.
206+
207+
================================================================
208+
Apache-2.0 licenses
209+
================================================================
210+
The following components are provided under the Apache-2.0 License. See project link for details.
211+
The text of each license is the standard Apache 2.0 license.
212+
213+
* dataclasses (https://github.com/ericvsmith/dataclasses)
214+
Files:
215+
pyfory/type_util.py (dataslots function)
216+
217+
* abseil-cpp (https://github.com/abseil/abseil-cpp)
218+
Compiled into the pyfory serialization extension module.
219+
Files:
220+
cpp/fory/thirdparty/flat_hash_map.h
221+
222+
================================================================
223+
MIT licenses
224+
================================================================
225+
The following components are provided under the MIT License. See project link for details.
226+
The text of each license is included below.
227+
228+
* fluentpython (https://github.com/fluentpython/example-code)
229+
Files:
230+
pyfory/type_util.py (record_class_factory function)
231+
232+
The MIT License (MIT)
233+
234+
Copyright (c) 2014 Luciano Ramalho
235+
236+
Permission is hereby granted, free of charge, to any person obtaining a copy
237+
of this software and associated documentation files (the "Software"), to deal
238+
in the Software without restriction, including without limitation the rights
239+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
240+
copies of the Software, and to permit persons to whom the Software is
241+
furnished to do so, subject to the following conditions:
242+
243+
The above copyright notice and this permission notice shall be included in all
244+
copies or substantial portions of the Software.
245+
246+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
247+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
248+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
249+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
250+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
251+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
252+
SOFTWARE.
253+
254+
255+
================================================================
256+
Public Domain
257+
================================================================
258+
The following components are placed in the public domain.
259+
The author hereby disclaims copyright to this source code.
260+
See project link for details.
261+
262+
* smhasher (https://github.com/aappleby/smhasher)
263+
Compiled into the pyfory mmh3 and serialization extension modules.
264+
Files:
265+
cpp/fory/thirdparty/MurmurHash3.cc
266+
cpp/fory/thirdparty/MurmurHash3.h

‎python/NOTICE‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
Apache Fory™
2+
Copyright 2023-2026 The Apache Software Foundation
3+
4+
This product includes software developed at
5+
The Apache Software Foundation (http://www.apache.org/).
6+
7+
================================================================
8+
9+
This product includes code with separate copyright notices and license terms.
10+
Your use of that code is subject to the terms and conditions of the licenses
11+
listed in LICENSE.
12+
13+
================================================================
14+
15+
dataclasses (https://github.com/ericvsmith/dataclasses)
16+
Copyright 2017-2022 Eric V. Smith, all rights reserved.

‎python/pyfory/type_util.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,10 @@ def normalize_fory_type(type_):
170170
return type_id
171171

172172

173-
# modified from `fluent python`
173+
# This function is derived from
174+
# https://github.com/fluentpython/example-code/blob/a7861802390010fc322f7fdbabf441ba36ed56f3/21-class-metaprog/factories.py.
175+
# Copyright (c) 2014 Luciano Ramalho.
176+
# Licensed under the MIT License; see licenses/LICENSE-fluentpython.txt.
174177
def record_class_factory(cls_name, field_names, *, publish=True):
175178
"""
176179
record_factory: create simple classes just for holding data fields

0 commit comments

Comments
 (0)