Moved Testcase to namespace test class

Author: bhattmanish98

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java

@@ -1530,7 +1530,7 @@ void setMaxBackoffIntervalMilliseconds(int maxBackoffInterval) {
 
   @VisibleForTesting
   public void setIsNamespaceEnabledAccount(Trilean isNamespaceEnabledAccount) {
-    isNamespaceEnabled = isNamespaceEnabledAccount;
+    this.isNamespaceEnabled = isNamespaceEnabledAccount;
   }
 
   /**

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java

@@ -1716,13 +1716,14 @@ protected String getUserAgent() {
    * Checks if the namespace is enabled.
    *
    * @return True if the namespace is enabled, false otherwise.
+   * @throws AbfsDriverException if the conversion fails.
    */
-  public boolean getIsNamespaceEnabled() throws TrileanConversionException {
+  public boolean getIsNamespaceEnabled() throws AbfsDriverException {
     try {
       return abfsConfiguration.getIsNamespaceEnabledAccount().toBoolean();
     } catch (TrileanConversionException ex) {
       LOG.error("Failed to convert namespace enabled account property to boolean", ex);
-      throw ex;
+      throw new AbfsDriverException("Failed to determine if namespace is enabled", ex);
     }
   }
 

hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsDfsClient.java

@@ -1563,10 +1563,11 @@ private Hashtable<String, String> parseCommaSeparatedXmsProperties(String xMsPro
    * @param requestHeaders list of headers to be sent with the request
    *
    * @return client transaction id
+   * @throws AzureBlobFileSystemException if an error occurs while generating the client transaction id
    */
   @VisibleForTesting
   public String addClientTransactionIdToHeader(List<AbfsHttpHeader> requestHeaders)
-  throws AzureBlobFileSystemException{
+      throws AzureBlobFileSystemException {
     String clientTransactionId = null;
     // Set client transaction ID if the namespace and client transaction ID config are enabled.
     if (getIsNamespaceEnabled() && getAbfsConfiguration().getIsClientTransactionIdEnabled()) {

hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestGetNameSpaceEnabled.java

@@ -29,6 +29,7 @@
 import org.apache.hadoop.fs.CommonConfigurationKeysPublic;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.azurebfs.constants.AbfsServiceType;
+import org.apache.hadoop.fs.azurebfs.constants.ConfigurationKeys;
 import org.apache.hadoop.fs.azurebfs.contracts.exceptions.AbfsRestOperationException;
 import org.apache.hadoop.fs.azurebfs.services.AbfsClient;
 import org.apache.hadoop.fs.azurebfs.services.AbfsDfsClient;
@@ -341,6 +342,66 @@ public void testAccountSpecificConfig() throws Exception {
     }
   }
 
+  /**
+   * Tests the behavior of AbfsConfiguration when the namespace-enabled
+   * configuration is not explicitly set (i.e., set to an empty string).
+   *
+   * Expects the namespace value to be set as UNKNOWN.
+   *
+   * @throws Exception if any error occurs during configuration setup or evaluation
+   */
+  @Test
+  public void testNameSpaceConfigNotSet() throws Exception {
+    Configuration configuration = new Configuration();
+    configuration.set(ConfigurationKeys.FS_AZURE_ACCOUNT_IS_HNS_ENABLED, "");
+    AbfsConfiguration abfsConfig = new AbfsConfiguration(configuration, "bogusAccountName");
+
+    // Test that the namespace enabled config is set correctly
+    Assertions.assertThat(abfsConfig.getIsNamespaceEnabledAccount())
+        .describedAs("Namespace enabled should be unknown in case config is not set")
+        .isEqualTo(Trilean.UNKNOWN);
+  }
+
+  /**
+   * Tests the behavior of AbfsConfiguration when the namespace-enabled
+   * configuration is explicitly set to "true".
+   *
+   * Expects the namespace value to be set as TRUE.
+   *
+   * @throws Exception if any error occurs during configuration setup or evaluation
+   */
+  @Test
+  public void testNameSpaceConfigSetToTrue() throws Exception {
+    Configuration configuration = new Configuration();
+    configuration.set(ConfigurationKeys.FS_AZURE_ACCOUNT_IS_HNS_ENABLED, "true");
+    AbfsConfiguration abfsConfig = new AbfsConfiguration(configuration, "bogusAccountName");
+
+    // Test that the namespace enabled config is set correctly
+    Assertions.assertThat(abfsConfig.getIsNamespaceEnabledAccount())
+        .describedAs("Namespace enabled should be true in case config is set to true")
+        .isEqualTo(Trilean.TRUE);
+  }
+
+  /**
+   * Tests the behavior of AbfsConfiguration when the namespace-enabled
+   * configuration is explicitly set to "false".
+   *
+   * Expects the namespace value to be set as FALSE.
+   *
+   * @throws Exception if any error occurs during configuration setup or evaluation
+   */
+  @Test
+  public void testNameSpaceConfigSetToFalse() throws Exception {
+    Configuration configuration = new Configuration();
+    configuration.set(ConfigurationKeys.FS_AZURE_ACCOUNT_IS_HNS_ENABLED, "false");
+    AbfsConfiguration abfsConfig = new AbfsConfiguration(configuration, "bogusAccountName");
+
+    // Test that the namespace enabled config is set correctly
+    Assertions.assertThat(abfsConfig.getIsNamespaceEnabledAccount())
+        .describedAs("Namespace enabled should be false in case config is set to false")
+        .isEqualTo(Trilean.FALSE);
+  }
+
   private void assertFileSystemInitWithExpectedHNSSettings(
       Configuration configuration, boolean expectedIsHnsEnabledValue) throws IOException {
     try (AzureBlobFileSystem fs = (AzureBlobFileSystem) FileSystem.newInstance(configuration)) {

hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestAbfsConfigurationFieldsValidation.java

@@ -31,7 +31,6 @@
 import org.apache.hadoop.fs.azurebfs.contracts.annotations.ConfigurationValidationAnnotations.LongConfigurationValidatorAnnotation;
 import org.apache.hadoop.fs.azurebfs.contracts.annotations.ConfigurationValidationAnnotations.Base64StringConfigurationValidatorAnnotation;
 import org.apache.hadoop.fs.azurebfs.contracts.exceptions.KeyProviderException;
-import org.apache.hadoop.fs.azurebfs.enums.Trilean;
 import org.apache.hadoop.fs.azurebfs.utils.Base64;
 
 import static org.apache.hadoop.fs.azurebfs.constants.ConfigurationKeys.FS_AZURE_SSL_CHANNEL_MODE_KEY;
@@ -211,66 +210,6 @@ public void testSSLSocketFactoryConfiguration()
             .isEqualTo(DelegatingSSLSocketFactory.SSLChannelMode.OpenSSL);
   }
 
-  /**
-   * Tests the behavior of AbfsConfiguration when the namespace-enabled
-   * configuration is not explicitly set (i.e., set to an empty string).
-   *
-   * Expects the namespace value to be set as UNKNOWN.
-   *
-   * @throws Exception if any error occurs during configuration setup or evaluation
-   */
-  @Test
-  public void testNameSpaceConfigNotSet() throws Exception {
-    Configuration configuration = new Configuration();
-    configuration.set(ConfigurationKeys.FS_AZURE_ACCOUNT_IS_HNS_ENABLED, "");
-    AbfsConfiguration abfsConfig = new AbfsConfiguration(configuration, "bogusAccountName");
-
-    // Test that the namespace enabled config is set correctly
-    Assertions.assertThat(abfsConfig.getIsNamespaceEnabledAccount())
-            .describedAs("Namespace enabled should be unknown in case config is not set")
-            .isEqualTo(Trilean.UNKNOWN);
-  }
-
-  /**
-   * Tests the behavior of AbfsConfiguration when the namespace-enabled
-   * configuration is explicitly set to "true".
-   *
-   * Expects the namespace value to be set as TRUE.
-   *
-   * @throws Exception if any error occurs during configuration setup or evaluation
-   */
-  @Test
-  public void testNameSpaceConfigSetToTrue() throws Exception {
-    Configuration configuration = new Configuration();
-    configuration.set(ConfigurationKeys.FS_AZURE_ACCOUNT_IS_HNS_ENABLED, "true");
-    AbfsConfiguration abfsConfig = new AbfsConfiguration(configuration, "bogusAccountName");
-
-    // Test that the namespace enabled config is set correctly
-    Assertions.assertThat(abfsConfig.getIsNamespaceEnabledAccount())
-            .describedAs("Namespace enabled should be true in case config is set to true")
-            .isEqualTo(Trilean.TRUE);
-  }
-
-  /**
-   * Tests the behavior of AbfsConfiguration when the namespace-enabled
-   * configuration is explicitly set to "false".
-   *
-   * Expects the namespace value to be set as FALSE.
-   *
-   * @throws Exception if any error occurs during configuration setup or evaluation
-   */
-  @Test
-  public void testNameSpaceConfigSetToFalse() throws Exception {
-    Configuration configuration = new Configuration();
-    configuration.set(ConfigurationKeys.FS_AZURE_ACCOUNT_IS_HNS_ENABLED, "false");
-    AbfsConfiguration abfsConfig = new AbfsConfiguration(configuration, "bogusAccountName");
-
-    // Test that the namespace enabled config is set correctly
-    Assertions.assertThat(abfsConfig.getIsNamespaceEnabledAccount())
-        .describedAs("Namespace enabled should be false in case config is set to false")
-        .isEqualTo(Trilean.FALSE);
-  }
-
   public static AbfsConfiguration updateRetryConfigs(AbfsConfiguration abfsConfig,
       int retryCount,
       int backoffTime) {