Skip to content

Commit 6bc7710

Browse files
committed
YARN-3369. Missing NullPointer check in AppSchedulingInfo causes RM to die. (Brahma Reddy Battula via wangda)
1 parent 1a4b528 commit 6bc7710

File tree

2 files changed

+9
-4
lines changed
  • hadoop-yarn-project
    • hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler

2 files changed

+9
-4
lines changed

hadoop-yarn-project/CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -802,6 +802,9 @@ Release 2.7.0 - UNRELEASED
802802
YARN-3379. Fixed missing data in localityTable and ResourceRequests table
803803
in RM WebUI. (Xuan Gong via jianhe)
804804

805+
YARN-3369. Missing NullPointer check in AppSchedulingInfo causes RM to die.
806+
(Brahma Reddy Battula via wangda)
807+
805808
Release 2.6.0 - 2014-11-18
806809

807810
INCOMPATIBLE CHANGES

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ synchronized public ResourceRequest getResourceRequest(Priority priority,
239239

240240
public synchronized Resource getResource(Priority priority) {
241241
ResourceRequest request = getResourceRequest(priority, ResourceRequest.ANY);
242-
return request.getCapability();
242+
return (request == null) ? null : request.getCapability();
243243
}
244244

245245
public synchronized boolean isBlacklisted(String resourceName) {
@@ -382,9 +382,11 @@ synchronized private void checkForDeactivation() {
382382
boolean deactivate = true;
383383
for (Priority priority : getPriorities()) {
384384
ResourceRequest request = getResourceRequest(priority, ResourceRequest.ANY);
385-
if (request.getNumContainers() > 0) {
386-
deactivate = false;
387-
break;
385+
if (request != null) {
386+
if (request.getNumContainers() > 0) {
387+
deactivate = false;
388+
break;
389+
}
388390
}
389391
}
390392
if (deactivate) {

0 commit comments

Comments
 (0)