Skip to content

Commit 583cb38

Browse files
committed
get latest_seq after lock
1 parent 2dcb801 commit 583cb38

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

src/server/server.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1215,11 +1215,11 @@ Server::InfoEntries Server::GetReplicationInfo() {
12151215
}
12161216

12171217
int idx = 0;
1218-
rocksdb::SequenceNumber latest_seq = storage->LatestSeqNumber();
12191218

12201219
{
12211220
std::shared_lock<std::shared_mutex> guard(slave_threads_mu_);
12221221
entries.emplace_back("connected_slaves", slave_threads_.size());
1222+
rocksdb::SequenceNumber latest_seq = storage->LatestSeqNumber();
12231223
for (const auto &slave : slave_threads_) {
12241224
if (slave->IsStopped()) continue;
12251225

@@ -1231,10 +1231,9 @@ Server::InfoEntries Server::GetReplicationInfo() {
12311231
slave_ack_seq >= latest_seq ? 0 : latest_seq - slave_ack_seq));
12321232
++idx;
12331233
}
1234+
entries.emplace_back("master_repl_offset", latest_seq);
12341235
}
12351236

1236-
entries.emplace_back("master_repl_offset", latest_seq);
1237-
12381237
return entries;
12391238
}
12401239

0 commit comments

Comments
 (0)