Skip to content

Don't test reproducibility on Windows#3668

Merged
ppkarwasz merged 1 commit into
2.xfrom
fix/reproducibility-on-windows
May 16, 2025
Merged

Don't test reproducibility on Windows#3668
ppkarwasz merged 1 commit into
2.xfrom
fix/reproducibility-on-windows

Conversation

@ppkarwasz

Copy link
Copy Markdown
Member

Due to CRLF vs. LF differences, artifacts generated on Linux cannot easily be reproduced on Windows.

We disable the reproducibility test on Windows.

Due to CRLF vs. LF differences, artifacts generated on Linux cannot easily be reproduced on Windows.

We disable the reproducibility test on Windows.
@ppkarwasz ppkarwasz added this to the 2.25.0 milestone May 16, 2025
@ppkarwasz ppkarwasz moved this from To triage to In review in Log4j bug tracker May 16, 2025
@ppkarwasz ppkarwasz self-assigned this May 16, 2025

@FreeAndNil FreeAndNil left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppkarwasz ppkarwasz merged commit b198245 into 2.x May 16, 2025
11 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in Log4j bug tracker May 16, 2025
@ppkarwasz ppkarwasz deleted the fix/reproducibility-on-windows branch May 16, 2025 20:38
@ppkarwasz

Copy link
Copy Markdown
Member Author

@FreeAndNil, thanks!

@vy

vy commented May 19, 2025

Copy link
Copy Markdown
Member

@ppkarwasz, IIRC, you had tweaked .gitattributes (and some other changes which I cannot recall right now) to support reproducible builds on Windows. Do we need to revert/adapt them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants