Skip to content

Commit f0f28e5

Browse files
rvessekwin
authored andcommitted
Revert inclusion of ci skip in release commit msg
This reverts PR #1423 which added the ci skip text into the default release commit. This broke many developers workflows because it pushes a choice about CI/CD process into default configuration. If developers genuinely want to skip CI/CD for the release commit then they already had configuration to override the commit message and inject the necessary ci skip text. However, the maven-release-plugin itself should not make any assumptions about developers CI/CD setups, nor do anything by default that might cause those to skip release commit builds that developers might be relying upon.
1 parent 2a82901 commit f0f28e5

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -281,18 +281,10 @@ public class PrepareReleaseMojo extends AbstractScmReadWriteReleaseMojo {
281281
* <li><code>artifactId</code> - The artifactId of the root project.
282282
* <li><code>releaseLabel</code> - The release version of the root project.
283283
* </ul>
284-
* It is recommended to automatically skip this commit from the default CI/CD build by including the string {@code ci skip}
285-
* in the commit message which is understood
286-
* by most CI systems, like <a href="https://docs.github.com/en/actions/how-tos/manage-workflow-runs/skip-workflow-runs">GitHub Actions</a>,
287-
* <a href="https://docs.gitlab.com/ci/pipelines/#skip-a-pipeline">GitLab Pipelines</a>, and probably some more.
288-
* Otherwise the non-SNAPSHOT version is built again (outside the actual release) and potentially also deployed somewhere
289-
* (which often leads to failed builds).
290284
* @since 3.0.0-M1
291285
*/
292-
@Parameter(
293-
defaultValue = "@{prefix} prepare release @{releaseLabel} [ci skip]",
294-
property = "scmReleaseCommitComment")
295-
private String scmReleaseCommitComment = "@{prefix} prepare release @{releaseLabel} [ci skip]";
286+
@Parameter(defaultValue = "@{prefix} prepare release @{releaseLabel}", property = "scmReleaseCommitComment")
287+
private String scmReleaseCommitComment = "@{prefix} prepare release @{releaseLabel}";
296288

297289
/**
298290
* The SCM commit comment for the commit setting pom.xml back to development version.

0 commit comments

Comments
 (0)