Skip to content

Commit 549253b

Browse files
committed
bugfix: renamed bcrypt algo name so it's usable, refactored algo name handling
1 parent 3927b9e commit 549253b

File tree

2 files changed

+6
-4
lines changed
  • crypto/support/hashes
    • argon2/src/main/java/org/apache/shiro/crypto/support/hashes/argon2
    • bcrypt/src/main/java/org/apache/shiro/crypto/support/hashes/bcrypt

2 files changed

+6
-4
lines changed

crypto/support/hashes/argon2/src/main/java/org/apache/shiro/crypto/support/hashes/argon2/Argon2Hash.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ class Argon2Hash extends AbstractCryptHash {
9090

9191
private static final Logger LOG = LoggerFactory.getLogger(Argon2Hash.class);
9292

93-
private static final Set<String> ALGORITHMS_ARGON2 = new HashSet<>(Arrays.asList("argon2id", "argon2i", "argon2d"));
93+
private static final Set<String> ALGORITHMS_ARGON2 = new HashSet<>(
94+
Arrays.asList(DEFAULT_ALGORITHM_NAME, "argon2i", "argon2d"));
9495

9596
private static final Pattern DELIMITER_COMMA = Pattern.compile(",");
9697

@@ -227,7 +228,7 @@ public static Argon2Hash generate(
227228
break;
228229
case "argon2":
229230
// fall through
230-
case "argon2id":
231+
case DEFAULT_ALGORITHM_NAME:
231232
type = Argon2Parameters.ARGON2_id;
232233
break;
233234
default:

crypto/support/hashes/bcrypt/src/main/java/org/apache/shiro/crypto/support/hashes/bcrypt/BCryptHash.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
*/
4242
class BCryptHash extends AbstractCryptHash {
4343

44-
public static final String DEFAULT_ALGORITHM_NAME = "2y";
44+
public static final String DEFAULT_ALGORITHM_NAME = "bcrypt2y";
4545

4646
public static final int DEFAULT_COST = 10;
4747

@@ -51,7 +51,8 @@ class BCryptHash extends AbstractCryptHash {
5151

5252
private static final Logger LOG = LoggerFactory.getLogger(AbstractCryptHash.class);
5353

54-
private static final Set<String> ALGORITHMS_BCRYPT = new HashSet<>(Arrays.asList("2", "2a", "2b", "2y"));
54+
private static final Set<String> ALGORITHMS_BCRYPT = new HashSet<>(
55+
Arrays.asList("bcrypt2", "bcrypt2a", "bcrypt2b", DEFAULT_ALGORITHM_NAME));
5556

5657
private final int cost;
5758

0 commit comments

Comments
 (0)