Skip to content

Logger propagate False prevents caplog from capturing logs during tests #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vdusek opened this issue Apr 23, 2025 · 0 comments
Open

Logger propagate False prevents caplog from capturing logs during tests #462

vdusek opened this issue Apr 23, 2025 · 0 comments
Assignees
@vdusek
Labels
t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@vdusek
Copy link
Contributor

vdusek commented Apr 23, 2025 •
edited
Loading

Setting logger.propagate to False in @apify/crawlee-python PR #1156 causes caplog to stop capturing logs. This is known pytest behavior (pytest-dev/pytest#3697).

This leads to failing log-related tests when using Crawlee v0.6.7 in apify-sdk-python PR #459.

Once this is resolved, undo the skip marks that were added in #459.
@vdusek vdusek assigned vdusek and unassigned vdusek Apr 23, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vdusek vdusek

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vdusek