ci: various linter / CI compiler error fixes

Includes changing TRUE to OP_TRUE for anyone-can-spend output name,
to avoid symbol conflict on win64 builds, which is really obnoxious.

Author: apoelstra

contrib/assets_tutorial/test_framework/authproxy.py

@@ -166,7 +166,7 @@ def _batch(self, rpc_call_list):
     def _get_response(self):
         try:
             http_response = self.__conn.getresponse()
-        except socket.timeout as e:
+        except socket.timeout:
             raise JSONRPCException({
                 'code': -344,
                 'message': '%r RPC took longer than %f seconds. Consider '

src/httpserver.cpp

@@ -24,7 +24,6 @@
 
 #include <sys/types.h>
 #include <sys/stat.h>
-#include <deque>
 
 #include <event2/thread.h>
 #include <event2/buffer.h>

src/init.cpp

@@ -2093,7 +2093,7 @@ bool AppInitMain(const util::Ref& context, NodeContext& node, interfaces::BlockA
     CScheduler::Function reevaluationLoop = [&node]{ node.reverification_scheduler->serviceQueue(); };
     threadGroup.create_thread(std::bind(&TraceThread<CScheduler::Function>, "reevaluation_scheduler", reevaluationLoop));
 
-    CScheduler::Function f2 = boost::bind(&MainchainRPCCheck, false);
+    CScheduler::Function f2 = std::bind(&MainchainRPCCheck, false);
     unsigned int check_rpc_every = gArgs.GetArg("-recheckpeginblockinterval", 120);
     if (check_rpc_every) {
         node.reverification_scheduler->scheduleEvery(f2, std::chrono::seconds(check_rpc_every));

src/pegins.cpp

@@ -456,7 +456,7 @@ std::vector<std::pair<CScript, CScript>> GetValidFedpegScripts(const CBlockIndex
 
     std::vector<std::pair<CScript, CScript>> fedpegscripts;
 
-    const int32_t epoch_length = params.dynamic_epoch_length;
+    const int32_t epoch_length = (int32_t) params.dynamic_epoch_length;
     const int32_t epoch_age = pblockindex->nHeight % epoch_length;
     const int32_t epoch_start_height = pblockindex->nHeight - epoch_age;
 

src/primitives/block.h

@@ -38,7 +38,7 @@ class CProof
         if (!(s.GetType() & SER_GETHASH))
             s >> *(CScriptBase*)(&solution);
     }
-         
+
     void SetNull()
     {
         challenge.clear();

src/qt/bitcoinamountfield.cpp

@@ -8,7 +8,6 @@
 #include <qt/guiconstants.h>
 #include <qt/guiutil.h>
 #include <qt/qvaluecombobox.h>
-#include <qt/guiutil.h>
 
 #include <assetsdir.h>
 #include <chainparams.h>

src/qt/qrimagewidget.cpp

@@ -67,7 +67,7 @@ bool QRImageWidget::setQR(const QString& data, const QString& text)
 
     // Elements: Hack to get QR address to print right
     const size_t MORE_WIDTH = 80;
-
+
     const int qr_image_size = QR_IMAGE_SIZE + MORE_WIDTH + (text.isEmpty() ? 0 : 2 * QR_IMAGE_MARGIN);
     QImage qrAddrImage(qr_image_size, qr_image_size, QImage::Format_RGB32);
     qrAddrImage.fill(0xffffff);

src/script/sign.cpp

@@ -178,7 +178,7 @@ static bool SignStep(const SigningProvider& provider, const BaseSignatureCreator
         sigdata.missing_witness_script = uint256(vSolutions[0]);
         return false;
 
-    case TxoutType::TRUE:
+    case TxoutType::OP_TRUE:
         return Params().anyonecanspend_aremine;
 
     default:

src/script/standard.cpp

@@ -69,7 +69,7 @@ std::string GetTxnOutputType(TxoutType t)
     case TxoutType::WITNESS_V0_SCRIPTHASH: return "witness_v0_scripthash";
     case TxoutType::WITNESS_V1_TAPROOT: return "witness_v1_taproot";
     case TxoutType::WITNESS_UNKNOWN: return "witness_unknown";
-    case TxoutType::TRUE: return "true";
+    case TxoutType::OP_TRUE: return "true";
     case TxoutType::FEE: return "fee";
     }
     assert(false);
@@ -126,7 +126,7 @@ TxoutType Solver(const CScript& scriptPubKey, std::vector<std::vector<unsigned c
     vSolutionsRet.clear();
 
     if (Params().anyonecanspend_aremine && scriptPubKey == CScript() << OP_TRUE) {
-        return TxoutType::TRUE;
+        return TxoutType::OP_TRUE;
     }
 
     // Fee outputs are for elements-style transactions only

src/script/standard.h

@@ -146,7 +146,7 @@ enum class TxoutType {
     WITNESS_V0_KEYHASH,
     WITNESS_V1_TAPROOT,
     WITNESS_UNKNOWN, //!< Only for Witness versions not already defined above
-    TRUE, // For testing purposes only
+    OP_TRUE, // For testing purposes only
     // ELEMENTS:
     FEE,
 };