executeOperation: Support TypedDocumentNode generic type
#7579
Unanswered
jangerhofer
asked this question in
Ideas
Replies: 1 comment 1 reply
-
|
@jangerhofer go for it, that'd be great! Happy to offer guidance as needed. Presumably adding Some tests which show the type correctness of using a |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Howdy, @glasser?
As @tobiasdiez (among others) commented,
ApolloServer.executeOperationsupport for theTypedDocumentNodeformat1 would advance type-safety for all who usegraphql-code-generatoralongside integration tests. I see that you both madeexecuteOperationgeneric over theTypedQueryDocumentNodetype fromgraphql-jsin #6960 and consideredTypedDocumentNodesupport around the same time. If I am not mistaken, such support never landed!I am eager to take a stab at making
apollo-serverplay nicely with thegraphql-code-generatorstandard in tests, but want to check(a) that you're still in favor of this change 😄 and
(b) whether you have any particular opinion about how to approach implementation.
Are you willing to offer guidance?
Footnotes
Specifically, support for inferring the
variablesparameter & return type ofexecuteOperationbased on the type of the GQL document passed as thequeryparameter. ↩Beta Was this translation helpful? Give feedback.
All reactions