Use getIntrospectionQuery instead of deprecated introspectionQuery constant #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derek-miller: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
…nstant from graphql-js
benjamn
approved these changes
Oct 24, 2019
| @@ -1,10 +1,11 @@ | |||
| import { GraphQLSchema, DocumentNode } from 'graphql'; | |||
| import { introspectionQuery, buildClientSchema, parse } from 'graphql'; | |||
| import { buildClientSchema, parse } from 'graphql'; | |||
| import { getIntrospectionQuery } from 'graphql/utilities'; | |||
There was a problem hiding this comment.
No need to change this before merging this PR, but we could make these imports more specific:
import { parse } from 'graphql/language/parser';
import { buildClientSchema } from 'graphql/utilities/buildClientSchema';
import { getIntrospectionQuery } from 'graphql/utilities/introspectionQuery';That said, what you've done is already an improvement over importing from 'graphql'.
|
Quick note: it looks like we will need to fix the failing tests on |
yaacovCR
pushed a commit
to yaacovCR/graphql-tools-fork
that referenced
this pull request
Dec 31, 2019
…nstant from graphql-js (ardatan#1228)
This was referenced Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introspectionQueryis being removed in v15 of graphql-js.