Skip to content

Commit 1735920

Browse files
committed
update to min py3.9 in build
1 parent 1fc2ec5 commit 1735920

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,15 @@ jobs:
6767
strategy:
6868
fail-fast: false
6969
matrix:
70-
python: ["3.8", "3.9", "3.10", "3.11", "3.12"]
70+
python: ["3.9", "3.10", "3.11", "3.12"]
7171
pytorch: ${{fromJson(needs.get-pytorch-versions.outputs.versions)}}
7272

7373
steps:
7474
- uses: actions/checkout@v4
7575

7676
- name: Inject (python / pytorch) test deps into pixi.toml / pyproject.toml
7777
run: |
78-
sed -i 's/python = "3.8.1"/python = "${{ matrix.python }}.*"/' pixi.toml
78+
sed -i 's/python = "3.9"/python = "${{ matrix.python }}.*"/' pixi.toml
7979
sed -i 's/torch>=2.0.0/torch~=${{ matrix.pytorch }}/' pyproject.toml
8080
8181
- uses: prefix-dev/[email protected]

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ By [Apoorv Khandelwal](http://apoorvkh.com) and [Peter Curtin](https://github.co
1616
pip install torchrunx
1717
```
1818

19-
Requires: Linux, Python >= 3.8.1, PyTorch >= 2.0
19+
Requires: Linux, Python >= 3.9, PyTorch >= 2.0
2020

2121
Shared filesystem & SSH access if using multiple machines
2222

docs/.readthedocs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: 2
33
build:
44
os: ubuntu-24.04
55
tools:
6-
python: "3.8"
6+
python: "3.9"
77

88
sphinx:
99
configuration: docs/source/conf.py

src/torchrunx/launcher.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ def execute_command(
136136
is_localhost = len(set(_host_addrs) & set(_localhost_addrs)) > 0
137137

138138
if is_localhost:
139-
# S602: subprocess.Popen is called with shell=True (https://docs.python.org/3.8/library/subprocess.html#security-considerations)
139+
# S602: subprocess.Popen is called with shell=True (https://docs.python.org/3.9/library/subprocess.html#security-considerations)
140140
# Made sure to shlex.quote arguments in build_command to prevent shell injection
141141
subprocess.Popen(command, shell=True, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL) # noqa: S602
142142
else:

0 commit comments

Comments
 (0)