Skip to content

Abstraction for logging class #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apoorvkh opened this issue Jul 30, 2024 · 1 comment · Fixed by #49
Closed

Abstraction for logging class #55

apoorvkh opened this issue Jul 30, 2024 · 1 comment · Fixed by #49

Comments

@apoorvkh
Copy link
Owner

Maybe we have a class

@dataclass
class LoggingConfig:
    handlers: dict[str, list[Handlers]]

    @classmethod
    def from_logfile(filepath, agents, workers) -> Self:
        pass

    # other builders

And then we can have functionality to merge multiple LoggingConfigs, e.g. with | operator

@pmcurtin pmcurtin linked a pull request Aug 13, 2024 that will close this issue
@apoorvkh
Copy link
Owner Author

apoorvkh commented Sep 2, 2024

we changed the design away from above idea

generally handled in #49

@apoorvkh apoorvkh closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant