Skip to content

visionOS should not show compatibility with the plugin #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
czechboy0 opened this issue Oct 9, 2023 · 2 comments
Closed

visionOS should not show compatibility with the plugin #327

czechboy0 opened this issue Oct 9, 2023 · 2 comments
Assignees
@simonjbeaumont
Labels
area/generator Affects: plugin, CLI, config file. kind/administration CI, repo automation, other admin tasks. size/S Small task. (A couple of hours of work.)
Milestone
1.0

Comments

@czechboy0
Copy link
Contributor

We only support macOS and Linux for running the build plugin, but SPI is also now showing visionOS. We should expand our #if guards.
@czechboy0 czechboy0 added area/generator Affects: plugin, CLI, config file. kind/administration CI, repo automation, other admin tasks. size/S Small task. (A couple of hours of work.) labels Oct 9, 2023
@czechboy0 czechboy0 added this to the 1.0 milestone Oct 9, 2023
@czechboy0
Copy link
Contributor Author

czechboy0 commented Oct 26, 2023 •
edited
Loading

We should double check when the visionOS platform name was added to SwiftPM, as this might require the 5.9 tools version - possibly blocked by #75.

@czechboy0 czechboy0 added the status/blocked Waiting for another issue. label Oct 26, 2023
@simonjbeaumont simonjbeaumont removed the status/blocked Waiting for another issue. label Nov 27, 2023
@simonjbeaumont
Copy link
Collaborator

I think we're fine.

We make the following check1, which should definitely fail on visionOS.

#if !(os(macOS) || os(Linux))
#error(
    "_OpenAPIGeneratorCore is only to be used by swift-openapi-generator itself—your target should not link this library or the command line tool directly."
)
#endif

Footnotes

  1. https://github.com/apple/swift-openapi-generator/blob/23073d4/Sources/_OpenAPIGeneratorCore/PlatformChecks.swift#L17-L21 ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonjbeaumont simonjbeaumont

Labels
area/generator Affects: plugin, CLI, config file. kind/administration CI, repo automation, other admin tasks. size/S Small task. (A couple of hours of work.)
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@simonjbeaumont @czechboy0