enhance configuraiton for dependencies mirrors#3670
Merged
Conversation
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
tomerd
force-pushed
the
refactor/configuration-mirrors
branch
from
0364556 to
077919f
Compare
Contributor
Author
Contributor
Author
|
@swift-ci please smoke test |
tomerd
commented
Aug 17, 2021
tomerd
commented
Aug 17, 2021
tomerd
commented
Aug 17, 2021
tomerd
commented
Aug 17, 2021
tomerd
commented
Aug 17, 2021
| try localFileSystem.createDirectory(newPath.parentDirectory, recursive: true) | ||
| try localFileSystem.move(from: legacyPath, to: newPath) | ||
| } | ||
| return newPath |
Contributor
Author
There was a problem hiding this comment.
@mattt @neonichu @abertelrud note the code above does the migration from old path to new one. we should carefully integrate that into the clients such as Xcode
Contributor
There was a problem hiding this comment.
Among the other development-oriented documents in SwiftPM, maybe we should have one specifically focused on clients like IDEs that calls out these things. Or maybe a separate section in the change log. Just a thought.
tomerd
commented
Aug 17, 2021
tomerd
commented
Aug 17, 2021
tomerd
commented
Aug 17, 2021
tomerd
force-pushed
the
refactor/configuration-mirrors
branch
from
077919f to
f49db9b
Compare
Contributor
Author
|
@swift-ci please smoke test |
tomerd
commented
Aug 17, 2021
Contributor
Author
|
@swift-ci please smoke test |
mattt
reviewed
Aug 17, 2021
mattt
reviewed
Aug 17, 2021
mattt
reviewed
Aug 17, 2021
mattt
reviewed
Aug 17, 2021
mattt
left a comment
mattt
left a comment
Contributor
There was a problem hiding this comment.
This is a nice improvement over what we have right now. I shared some ideas about the API design, but overall things are looking good.
Contributor
Author
@swift-ci please smoke test linux |
tomerd
added
the
ready
motivation: support both local and global configuraiton, as per SE-0292 changes: * reafactor and seperate out the mirrors data model from the loading/saving mutation utility * use Codable for serialization * add new utility to manage local and shared mirrors configuraiton files * add new CLI flag to set custom shared configuration path * adjust call sites * add tests
tomerd
force-pushed
the
refactor/configuration-mirrors
branch
from
3fe1921 to
fc30632
Compare
Contributor
Author
|
@swift-ci please smoke test |
tomerd
force-pushed
the
refactor/configuration-mirrors
branch
from
fc30632 to
dc0f251
Compare
Contributor
Author
|
@swift-ci please smoke test |
abertelrud
reviewed
Aug 19, 2021
| } else { | ||
| diagnostics.emit(warning: "Did not find optional .netrc file at \(resolvedPath.pathString).") | ||
| return nil | ||
| return .none |
Contributor
There was a problem hiding this comment.
I've noticed this change a couple of diffs. Is this the recommended style for conditionals?
Contributor
Author
There was a problem hiding this comment.
I prefer to use .none when the optional marks a clear functional decision, e.g. let cache = .none is more semantic in my mind then let cache = nil
Contributor
There was a problem hiding this comment.
Agreed. I'll start doing the same, and if/when we do a swift-format pass on the whole codebase we can do the rest then.
Contributor
Author
|
Contributor
Author
|
@swift-ci please smoke test linux |
abertelrud
approved these changes
Aug 19, 2021
This was referenced Aug 23, 2021
mattt
added a commit
to swiftlang/swift-evolution
that referenced
this pull request
Aug 30, 2021
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation: support both local and global configuraiton, as per SE-0292
changes: