Conversation
Resolves rdar://87583788
|
@swift-ci test |
|
@swift-ci please smoke test |
|
swiftlang/swift-llbuild#758 |
|
swiftlang/swift-llbuild#758 |
|
swiftlang/swift-llbuild#758 |
|
@elsh in order to build a toolchain, you need to create a PR on the swift repositories and then mention all the related PR (like this one and the llbuild one) for cross repo building. iow, the SwiftPM repo is not setup to create toolchains, you have to create an empty PR on the swift toolchain to do that. |
tomerd
left a comment
There was a problem hiding this comment.
very nice. couple of small comments
|
probably worth adding at least one fixtures in the functional tests area for a end-to-end test of the functionality |
|
@swift-ci smoke test |
Planning to add that in a separate PR; lmk if you think it should accompany this PR. |
|
@swift-ci smoke test |
|
i think at least one end-to-end (fixture) test is in place |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
tomerd
left a comment
There was a problem hiding this comment.
looks good once fixture path are fixed
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
🥳 |
Resolves rdar://87583788