Skip to content

Support Module aliasing in SwiftPM#4023

Merged
elsh merged 19 commits into
mainfrom
es-mod
Feb 9, 2022
Merged

Support Module aliasing in SwiftPM#4023
elsh merged 19 commits into
mainfrom
es-mod

Conversation

@elsh

@elsh elsh commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

Resolves rdar://87583788

Resolves rdar://87583788
@elsh

elsh commented Jan 14, 2022

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@tomerd

tomerd commented Jan 15, 2022

Copy link
Copy Markdown
Contributor

@swift-ci please smoke test

@elsh

elsh commented Jan 15, 2022

Copy link
Copy Markdown
Contributor Author

swiftlang/swift-llbuild#758
@swift-ci smoke test

@elsh

elsh commented Jan 17, 2022

Copy link
Copy Markdown
Contributor Author

swiftlang/swift-llbuild#758
@swift-ci smoke test

@elsh

elsh commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

swiftlang/swift-llbuild#758
@swift-ci Please Build Toolchain macOS Platform

@tomerd

tomerd commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

@elsh in order to build a toolchain, you need to create a PR on the swift repositories and then mention all the related PR (like this one and the llbuild one) for cross repo building. iow, the SwiftPM repo is not setup to create toolchains, you have to create an empty PR on the swift toolchain to do that.

Comment thread Sources/PackageDescription/Target.swift Outdated
Comment thread Sources/PackageGraph/PackageGraph+Loading.swift Outdated
Comment thread Sources/PackageGraph/PackageGraph+Loading.swift Outdated
Comment thread Sources/PackageModel/Manifest/TargetDescription.swift Outdated
Comment thread Sources/PackageModel/ManifestSourceGeneration.swift Outdated
Comment thread Sources/PackageModel/Target.swift Outdated
Comment thread Sources/PackageModel/Target.swift Outdated
Comment thread Tests/BuildTests/BuildPlanTests.swift Outdated
Comment thread Sources/LLBuildManifest/Tools.swift
Comment thread Sources/PackageGraph/PackageGraph+Loading.swift Outdated
Comment thread Tests/BuildTests/BuildPlanTests.swift
Comment thread Tests/BuildTests/BuildPlanTests.swift

@tomerd tomerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. couple of small comments

@tomerd

tomerd commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

probably worth adding at least one fixtures in the functional tests area for a end-to-end test of the functionality

@elsh

elsh commented Feb 4, 2022

Copy link
Copy Markdown
Contributor Author

@swift-ci smoke test

@elsh

elsh commented Feb 4, 2022

Copy link
Copy Markdown
Contributor Author

probably worth adding at least one fixtures in the functional tests area for a end-to-end test of the functionality

Planning to add that in a separate PR; lmk if you think it should accompany this PR.

@elsh

elsh commented Feb 5, 2022

Copy link
Copy Markdown
Contributor Author

@swift-ci smoke test

@tomerd

tomerd commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

i think at least one end-to-end (fixture) test is in place

@elsh

elsh commented Feb 8, 2022

Copy link
Copy Markdown
Contributor Author

@swift-ci smoke test

@elsh

elsh commented Feb 8, 2022

Copy link
Copy Markdown
Contributor Author

@swift-ci smoke test

Comment thread Fixtures/Miscellaneous/ModuleAliasing/Simple/appPkg/Package.swift
Comment thread Fixtures/Miscellaneous/ModuleAliasing/Simple/gamePkg/Package.swift Outdated

@tomerd tomerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good once fixture path are fixed

@elsh

elsh commented Feb 8, 2022

Copy link
Copy Markdown
Contributor Author

@swift-ci smoke test

@elsh

elsh commented Feb 9, 2022

Copy link
Copy Markdown
Contributor Author

@swift-ci smoke test

@elsh elsh merged commit 956eba8 into main Feb 9, 2022
@tomerd

tomerd commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants