[stdlib] default separator for joining strings (SE-0133)#3838
Merged
tkremenek merged 1 commit intoswiftlang:masterfrom Jul 29, 2016
Merged
[stdlib] default separator for joining strings (SE-0133)#3838tkremenek merged 1 commit intoswiftlang:masterfrom
tkremenek merged 1 commit intoswiftlang:masterfrom
Conversation
jtbandes
force-pushed
the
se-0133-2
branch
2 times, most recently
from
979ad27 to
e0f8f4b
Compare
1 task
Contributor
|
LGTM! Seems like we already are special-casing zero-length separators, great, no extra work performance is needed then. @swift-ci Please test |
Contributor
Author
|
Yep. If we wanted, we could have fully separate implementations to avoid a little bit of arithmetic with the |
Contributor
|
@jtbandes I think that arithmetic overhead does not matter in practice. |
Contributor
Author
|
Looks like an IDE test needed to be updated. Fixed. |
Contributor
|
@swift-ci Please test |
Contributor
Author
|
The failure on Linux looks unrelated, but I'm not sure. |
Member
|
Yes, I think it is unrelated. |
Contributor
Author
|
🎊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per SE-0133 rename
flatten()tojoined(),Sequence<String>.joined(separator:)should have a default separator of"".Cleaned up the Join tests slightly; they were weirdly-structured due to organic growth back when
joinwas a free function.cc @dabrahams @tkremenek
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.