Parsing generic subscripts #7697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
commented
Feb 23, 2017
| // Code completion for the generic type params. | ||
| // | ||
| // FIXME: What is this? | ||
| if (GPHasCodeCompletion) |
There was a problem hiding this comment.
@nkcsgexi How do I test these 'code completion' code paths in the parser correctly?
slavapestov
force-pushed
the
parsing-generic-subscripts
branch
from
2f0d81c to
86cd479
Compare
DougGregor
reviewed
Feb 23, 2017
lib/AST/Decl.cpp
Outdated
| for (auto param : getParams()) { | ||
| auto *decl = new (ctx) GenericTypeParamDecl( | ||
| dc, param->getName(), param->getNameLoc(), | ||
| 0xFFFF, param->getIndex()); |
There was a problem hiding this comment.
Okay, this is my fault, but that 0xFFFF should probably become a named constant.
lib/Sema/TypeCheckDecl.cpp
Outdated
| @@ -4813,6 +4813,17 @@ class DeclChecker : public DeclVisitor<DeclChecker> { | |||
| } | |||
| } | |||
|
|
|||
| #if 0 | |||
slavapestov
force-pushed
the
parsing-generic-subscripts
branch
from
86cd479 to
41c965b
Compare
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
parsing-generic-subscripts
branch
from
41c965b to
b5d7d2d
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
This will be immediately needed for generic subscripts, and also for fixing the remaining cases where initializer inheritance doesn't work.
slavapestov
force-pushed
the
parsing-generic-subscripts
branch
from
b5d7d2d to
9c91181
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
parsing-generic-subscripts
branch
from
9c91181 to
928a74c
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #7683 has landed, this adds parser support. The only tricky thing here is that since accessors for a subscript are not nested inside the subscript itself, we have to clone the generic parameter list of the subscript for each accessor, since otherwise name lookup won't find the generic parameters.
The main thing that remains now is SILGen support. Some simple examples I tried work, but I need to exercise the corner cases more, in particular materializeForSet, and actually write proper tests.