Skip to content

SM Library #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichelRichir opened this issue Feb 7, 2016 · 11 comments
Closed

SM Library #4537

MichelRichir opened this issue Feb 7, 2016 · 11 comments
Assignees
Labels
Type: Duplicate Another item already exists for this topic
Milestone

Comments

@MichelRichir
Copy link

SM library works fine with Arduino 1.6.5 but not with Arduino 1.6.7

@per1234
Copy link
Collaborator

per1234 commented Feb 7, 2016

Since you haven't provided any information of where you downloaded the SM library(http://playground.arduino.cc/Code/SMlib ?) or what the problem you're encountering is I have to do some guesswork but I believe this is a duplicate of arduino/arduino-builder#50. So, using the example_2 example, you would need to change the line:

SM Simple(S1);//create simple statemachine

to:

SM Simple(&S1);//create simple statemachine

@agdl agdl added the Component: Board/Lib Manager Boards Manager or Library Manager label Feb 8, 2016
@agdl agdl added this to the Release 1.6.8 milestone Feb 8, 2016
@agdl agdl self-assigned this Feb 8, 2016
@agdl agdl removed the Component: Board/Lib Manager Boards Manager or Library Manager label Feb 8, 2016
@agdl
Copy link
Member

agdl commented Feb 8, 2016

Looking at the history maybe you can ask to the contributor to make the change or maybe someone can upload the library on Git and insert it in the library manager in this way you don't have to add it manually and someone else can easily find it

@per1234
Copy link
Collaborator

per1234 commented Feb 8, 2016

I agree it would be good to update the library. There is also an issue with example_1.ino where the case of the folder name doesn't match the case of the filename so it won't compile. @agdl do you know whether it is possible to do attachments on the Playground anymore? I just did a test in the sandbox http://playground.arduino.cc/Main/WikiSandbox but when I click on that link to do the upload the password prompt won't let me past with the prefilled password. I'll send the library author a PM to ask if they'd like to update the library but I'd like to be able to give them the correct information regarding the attachment issue. I always prefer to see libraries on GitHub and I am willing to create a repository for the library if the author has abandoned it.

@agdl
Copy link
Member

agdl commented Feb 8, 2016

@per1234 I'm too too expert of playground, but maybe if there are issue @mastrolinux can help!

@mastrolinux
Copy link
Contributor

Hi @per1234 the upload feature is restricted to some users only. If they can provide us an updated file we can upload it.
Thank you.

@per1234
Copy link
Collaborator

per1234 commented Feb 15, 2016

@mastrolinux thanks for the information. I think that was a good idea. It's better for files to be hosted elsewhere and just put a link to it on the playground. I have documented that regular users are no longer allowed to attach files in the Participate page of the Playground.

I sent the library author a PM via the Arduino website to notify them of this issue.

@agdl
Copy link
Member

agdl commented Feb 22, 2016

@per1234 can this be closed?

@per1234
Copy link
Collaborator

per1234 commented Feb 22, 2016

@agdl I think so. I haven't received a response to my message to the author but another user has created a repository for the library https://github.com/dangu/SMlib and we have fixed the examples there so they will compile with Arduino IDE 1.6.6+.

@agdl
Copy link
Member

agdl commented Feb 22, 2016

thank you!

@dangu
Copy link

dangu commented Feb 23, 2016

@per1234: May I kindly ask you to remove your SMlib-repo from github. I apparently did something horribly wrong creating this repository.

@per1234
Copy link
Collaborator

per1234 commented Feb 23, 2016

@dangu I have done so. The purpose of my fork was only to contribute the pull requests I made to your repository and I had just not gotten around to deleting it yet.

So just to make it clear to others who may encounter this issue report in the future, the SM library has been removed by the author from the Arduino Playground as well as all copies of it from GitHub and is no longer publicly available. So this means this issue has been resolved in a completely different manner than I had stated in my last comment.

@per1234 per1234 added the Type: Duplicate Another item already exists for this topic label Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Duplicate Another item already exists for this topic
Projects
None yet
Development

No branches or pull requests

5 participants