Berry make Leds animate calls reentrant#22643
Merged
Merged
Conversation
Contributor
|
It would be a cool thing to recreate the WLED garage door animation with Tasmota and Berry :-) |
Collaborator
Author
|
What is the garage door animation ? |
Contributor
|
Watch the linked video :-) |
Collaborator
Author
|
It should be now doable with some Berry glue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Since the new TasmotaLED driver, it was not possible to apply multiple times the same animation code because resources were exclusive. Now automagic is done so that previous Led and animate are reused or stopped.
Ex, you can enter mulitple times the following code:
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass