Skip to content

feat(locales): add Greek (el-GR) and Romanian (ro-RO) #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kmoutzou
Copy link
Contributor

@kmoutzou kmoutzou commented Sep 27, 2021

Datepicker localization in Greek language.
Datepicker localization in Romanian language.

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

Datepicker localization in Romanian language.
@vercel
Copy link

vercel bot commented Sep 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/3YN68QAxDGXxXR69dJrM95bdCKG1
✅ Preview: Failed

@kmoutzou
Copy link
Contributor Author

kmoutzou commented Oct 6, 2021

@JorgenVatle hello, please if possible, merge the localization changes i added for Romanian and Greek languages. I have no idea why the pull request does not get accepted by the automatic system, the changes are very simple json changes, nothing it should have issues with..

Copy link
Contributor

@JorgenVatle JorgenVatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe I have permission to merge, but the changes look good to me. 👍

@kmoutzou
Copy link
Contributor Author

kmoutzou commented Oct 6, 2021

Thanks for quick response! Sorry, i thought u had permissions, maybe @arthurdenner then?

@arthurdenner arthurdenner changed the title Datepicker localization in Greek and Romanian language. feat(locales): add Greek (el-GR) and Romanian (ro-RO) Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #650 (8005c60) into develop (8407575) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #650      +/-   ##
===========================================
+ Coverage    95.37%   95.41%   +0.04%     
===========================================
  Files           16       16              
  Lines          519      524       +5     
  Branches        99      100       +1     
===========================================
+ Hits           495      500       +5     
  Misses          24       24              
Impacted Files Coverage Δ
src/index.tsx 94.05% <0.00%> (+0.03%) ⬆️
src/utils.ts 98.14% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8407575...8005c60. Read the comment docs.

@arthurdenner arthurdenner merged commit 578dc27 into arthurdenner:develop Oct 11, 2021
@arthurdenner
Copy link
Owner

@kmoutzou, thank you for your contribution.
You'll be notified here when this PR is released.

Please keep in mind that every person has different availability.

@github-actions
Copy link

🎉 This PR is included in version 2.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arthurdenner
Copy link
Owner

@allcontributors please add @kmoutzou for code.

@allcontributors
Copy link
Contributor

@arthurdenner

I've put up a pull request to add @kmoutzou! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants