Hosting now requires ctrl + c to exit instead of enter

[davidfowl]

This was a design change that allows command line hosting to be run without a tty

[miguellira]

Ugh. Looks like this change brought this back aspnet/KestrelHttpServer#9

Unhandled Exception:
System.Exception: Error -16 EBUSY resource busy or locked
  at Microsoft.AspNet.Server.Kestrel.Networking.Libuv.Check (Int32 statusCode) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Server.Kestrel.Networking.Libuv.loop_close (Microsoft.AspNet.Server.Kestrel.Networking.UvLoopHandle handle) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Server.Kestrel.Networking.UvLoopHandle.ReleaseHandle () [0x00000] in <filename unknown>:0 
  at System.Runtime.InteropServices.SafeHandle.Dispose (Boolean disposing) [0x00000] in <filename unknown>:0 
  at System.Runtime.InteropServices.SafeHandle.Finalize () [0x00000] in <filename unknown>:0 

[davidfowl]

Nice

[hnrkndrssn]

Was that fixed?

I get that occasionally on beta4...

dnx . kestrel
Started


Unhandled Exception:
System.Exception: Error -16 EBUSY resource busy or locked
  at Microsoft.AspNet.Server.Kestrel.Networking.Libuv.Check (Int32 statusCode) [0x00000] in <filename unknown>:0
  at Microsoft.AspNet.Server.Kestrel.Networking.Libuv.loop_close (Microsoft.AspNet.Server.Kestrel.Networking.UvLoopHandle handle) [0x00000] in <filename unknown>:0
  at Microsoft.AspNet.Server.Kestrel.Networking.UvLoopHandle.ReleaseHandle () [0x00000] in <filename unknown>:0
  at System.Runtime.InteropServices.SafeHandle.Dispose (Boolean disposing) [0x00000] in <filename unknown>:0
  at System.Runtime.InteropServices.SafeHandle.Finalize () [0x00000] in <filename unknown>:0

dnvm list

Active Version              Runtime Arch Location             Alias
------ -------              ------- ---- --------             -----
  *    1.0.0-beta4          mono         ~/.dnx/runtimes      default
       1.0.0-beta5-11533    mono         ~/.dnx/runtimes
       1.0.0-beta5-11657    mono         ~/.dnx/runtimes
       1.0.0-beta5-11672    mono         ~/.dnx/runtimes

[miguellira]

@alfhenrik don't know. Maybe. I wasn't on beta4 on the Mac for long. Didn't come across it on beta5 until this change though. Oh well, it's all beta anyway.

[Tragetaschen]

This hasn't been resolved in Kestrel yet.

If you did CTRL+C to a running application before, then the application would call the equivalent of Environment.Exit and let the finalizers (hopefully) clean up the application, if at all. With this change now, the actual Dispose logic of Kestrel is running.

There is no difference between pressing Enter before and CTRL+C now.

[davidfowl]

Thanks for that confirmation @Tragetaschen

[Tragetaschen]

Ah, there's one difference in behavior, though: The exception from the Dispose call isn't logged / swallowed anymore, but goes right out of Hosting's Main method to the layers above. With the "old" behavior, if you didn't use a logger like the console logger, you wouldn' see it.

[adamralph]

tty?

[uatec]

A terminal. When running as a daemon on *nix the terminal is not available by default. For example running kestrel in docker required The container to be attached to a terminal.

[adamralph]

I see, thanks. Makes sense. I had exactly the same problem at adamralph/scriptcs-nancy#96