-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Is this OAuth or something else? #11318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello! Thanks for contacting us. This sounds like a general question about using ASP.NET Core. While we try to look at and respond to all issues, for questions like this we recommend posting to a community support group like Stack Overflow with the |
@rwwilden @Rick-Anderson Looks like this example is using the OIDC implicit flow which is no longer recommended. The js lib used here also supports the 'code' flow. Maybe you could consider updating this. |
@Rick-Anderson this was not a general question about ASP.NET Core but a specific question on the type of OAuth flow that is used to authorize users in the article. It seems that implicit flow is used. The next question then is what @damienbod also says: the OIDC implicit flow is no longer recommended so maybe it's a good idea to use authorization code flow with PKCE. |
@Tratcher please review |
This is me, not @Tratcher |
No actually. It's identity server. |
No, it’s me. It’s a question about our support. |
@javiercn yes the template is using 'token id_token'. If you switched to code with PKCE, this would not be much effort and a better solution. (silent renew as it is, not refresh tokens) It should also be mentioned that cookies are a good solution when using same domain for API and UI. Greetings Damien |
Sorry @javiercn, I'd read that wrong on my phone. I thought you had assigned it to me. |
I made a blog about choosing the best flow for this type of app. Maybe you could update the docs with something like this https://damienbod.com/2019/04/02/securing-browser-based-javascript-typescript-applications/ |
Unable to run the command Invalid input switch: |
@BDTomasz |
When will the documentation be updated for recommended approach to authentication for SPAs? |
@damienbod I have seen you comments, which reflect that implicit flow is not recommended, it would be great if you can create an example of this based on the example above, if it's not too much effort to extend it.. that would be a great help. Also if we can get an example of accessing the user claims etc on the server that would be a bonus... |
We moved to code+pkce as of preview8 |
@javiercn : ok great, I think I am looking at preview6 and now see a preview7, do I need to wait for preview8? |
Yes. |
@javiercn - could you please link to the work-item issue for the code+pkce changes? |
7bf660947baf8966cd65ae6a3708cf283576dc25 |
I really like that IdentityServer is integrated but I do not understand what the flow is for getting an access token. This is directed at SPAs so is this the OAuth implicit flow? And if so, what are the thoughts about implicit flow no longer being advised by the OAuth working group (https://brockallen.com/2019/01/03/the-state-of-the-implicit-flow-in-oauth2/, https://medium.com/oauth-2/why-you-should-stop-using-the-oauth-implicit-grant-2436ced1c926).
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: