-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Remove Cookie Consent UI from all templates and move into docs #10346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
will this mean it's gone from all asp.net core templates? mvc, etc? |
Clarified the title. Thanks for the eagle eye @brockallen. |
So that's fuckin' awesome -- I can't tell you how many web apps I create from File->New Project and that's the first thing I have to delete. Wahoo! |
Remove Cookie Consent UI from all templates and move into docs #10346
Removing the cookie-consent is done, now we just have to include it in the docs. |
@scottaddie do you need an issue to track the doc changes? I can probably add a section that shows the UI and Middleware if you point me to what doc it should go in |
@isaac2004 Yes, please create an issue for this. The following doc would need to be updated for 3.0: https://docs.microsoft.com/en-us/aspnet/core/security/gdpr. |
@scottaddie done! |
@ryanbrandenburg just realized I forgot to remove Privacy views. Since Cookie consent loads these, should they be removed as well? |
The Privacy page is also referenced in the footer (_Layout.cshtml), so we should keep that page. |
@ryanbrandenburg FYI docs have been updated as well |
Cool, once that PR is merged/approved we can close this out. |
@ryanbrandenburg @mkArtakMSFT the doc has been updated |
Thanks @isaac2004! @ryanbrandenburg looks like nothing else left in here to do. If so, please move this back to |
The Cookie Consent UI should not be part of templates any more. We should, instead, turn the current state into docs for customers to enable, if you wish.
The text was updated successfully, but these errors were encountered: