Skip to content

Remove Cookie Consent UI from all templates and move into docs #10346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkArtakMSFT opened this issue May 17, 2019 · 13 comments
Closed

Remove Cookie Consent UI from all templates and move into docs #10346

mkArtakMSFT opened this issue May 17, 2019 · 13 comments
Assignees
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@mkArtakMSFT
Copy link
Member

The Cookie Consent UI should not be part of templates any more. We should, instead, turn the current state into docs for customers to enable, if you wish.

@mkArtakMSFT mkArtakMSFT added 1 - Ready enhancement This issue represents an ask for new feature or an enhancement to an existing one area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 17, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview7 milestone May 17, 2019
@brockallen
Copy link

will this mean it's gone from all asp.net core templates? mvc, etc?

@ryanbrandenburg ryanbrandenburg changed the title Remove Cookie Consent UI from the Web App template into docs Remove Cookie Consent UI from all templates and move into docs May 17, 2019
@ryanbrandenburg
Copy link
Contributor

Clarified the title. Thanks for the eagle eye @brockallen.

@brockallen
Copy link

So that's fuckin' awesome -- I can't tell you how many web apps I create from File->New Project and that's the first thing I have to delete. Wahoo!

ryanbrandenburg added a commit that referenced this issue Jun 5, 2019
Remove Cookie Consent UI from all templates and move into docs #10346
@ryanbrandenburg
Copy link
Contributor

Removing the cookie-consent is done, now we just have to include it in the docs.

@isaacrlevin
Copy link
Contributor

@scottaddie do you need an issue to track the doc changes? I can probably add a section that shows the UI and Middleware if you point me to what doc it should go in

@scottaddie
Copy link
Member

@isaac2004 Yes, please create an issue for this. The following doc would need to be updated for 3.0: https://docs.microsoft.com/en-us/aspnet/core/security/gdpr.

@isaacrlevin
Copy link
Contributor

@scottaddie done!

@isaacrlevin
Copy link
Contributor

@ryanbrandenburg just realized I forgot to remove Privacy views. Since Cookie consent loads these, should they be removed as well?

@ryanbrandenburg
Copy link
Contributor

The Privacy page is also referenced in the footer (_Layout.cshtml), so we should keep that page.

@isaacrlevin
Copy link
Contributor

@ryanbrandenburg FYI docs have been updated as well

@ryanbrandenburg
Copy link
Contributor

Cool, once that PR is merged/approved we can close this out.

@isaacrlevin
Copy link
Contributor

@ryanbrandenburg @mkArtakMSFT the doc has been updated
dotnet/AspNetCore.Docs#12720

@mkArtakMSFT
Copy link
Member Author

Thanks @isaac2004!

@ryanbrandenburg looks like nothing else left in here to do. If so, please move this back to Preview7 and close as Done.

@mkArtakMSFT mkArtakMSFT added the Done This issue has been fixed label Jun 18, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

No branches or pull requests

5 participants