Skip to content

Update project templates to use LibMan #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DamianEdwards opened this issue Apr 13, 2018 · 5 comments
Closed

Update project templates to use LibMan #5415

DamianEdwards opened this issue Apr 13, 2018 · 5 comments
Assignees
@danroth27
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one Needs: Spec Indicates that a spec defining user experience is required
Milestone
Backlog

Comments

@DamianEdwards
Copy link
Member

LibMan now ships in VS 15.7. It will soon be followed by a CLI tool that will enable it for cmd line scenarios. When that happens, we need to update the templates to use LibMan for managing client dependencies. This will involve including a libman.json file in the root of the projects, configured to bring in the required client libs (jQuery, jQuery Validate, jQuery Validation Unobtrusive, and Bootstrap).

Note this is blocked on getting confirmation from @ChrisSfanos RE approval/requirements for using cdnjs as the configured source in VS and templates.
@guardrex
Copy link
Contributor

For our upcoming docs issue(s), is it likely that LibMan will become part of the templates for 2.2?

@DamianEdwards
Copy link
Member Author

Very, possibly earlier (in a 2.1.x patch)

@danroth27
Copy link
Member

LibMan was pulled from VS2017 15.7, because it wasn't quite ready yet, but it's still being actively worked on so we should keep this bug to track the template integration.

@aspnet-hello aspnet-hello transferred this issue from aspnet/Templating Dec 17, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0-preview1 milestone Dec 17, 2018
@aspnet-hello aspnet-hello added 1 - Ready area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Dec 17, 2018
@Eilon Eilon modified the milestones: 3.0.0-preview1, 3.0.0-preview2 Dec 18, 2018
@mkArtakMSFT mkArtakMSFT added the Needs: Spec Indicates that a spec defining user experience is required label Mar 9, 2019
@ryanbrandenburg
Copy link
Contributor

Any progress on this @danroth27? Using LibMan would make it much easier to work in our templates, in addition to making it easier for customers to upgrade these components after template creation.

@ryanbrandenburg ryanbrandenburg mentioned this issue Apr 4, 2019
Closed
@DamianEdwards DamianEdwards mentioned this issue May 17, 2019
Closed
@scottaddie scottaddie mentioned this issue Jul 8, 2019
Merged
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.1.0, Backlog Aug 27, 2019
@mkArtakMSFT
Copy link
Contributor

Closing this as there are no clear plans around LibMan at the moment.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danroth27 danroth27

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates enhancement This issue represents an ask for new feature or an enhancement to an existing one Needs: Spec Indicates that a spec defining user experience is required
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@Eilon @DamianEdwards @guardrex @danroth27 @ryanbrandenburg @mkArtakMSFT @aspnet-hello