Skip to content

Remove MessagePack dependency from Razor Components #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkArtakMSFT opened this issue Feb 6, 2019 · 2 comments
Closed

Remove MessagePack dependency from Razor Components #7311

mkArtakMSFT opened this issue Feb 6, 2019 · 2 comments
Assignees
@pranavkm
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Components Big Rock This issue tracks a big effort which can span multiple issues Done This issue has been fixed External This is an issue in a component not contained in this repository. It is open for tracking purposes.
Milestone
3.0.0-preview4

Comments

@mkArtakMSFT
Copy link
Member

mkArtakMSFT commented Feb 6, 2019 •
edited by rynowak
Loading

We need to remove the dependency on message pack so that Razor Components can ship in the shared framework.

The work here is to procure a replacement lite message pack serializer that we can use as an implementation detail (provided by signalR) - and then adopt it.
@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. 1 - Ready labels Feb 6, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview5 milestone Feb 6, 2019
@mkArtakMSFT mkArtakMSFT added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-blazor Includes: Blazor, Razor Components labels Feb 6, 2019
@danroth27
Copy link
Member

This is an ask on the SignalR folks: #7387.

@danroth27 danroth27 added the External This is an issue in a component not contained in this repository. It is open for tracking purposes. label Feb 8, 2019
@BrennanConroy
Copy link
Member

I believe @pranavkm has been working on a prototype for this

@rynowak rynowak added the Components Big Rock This issue tracks a big effort which can span multiple issues label Mar 4, 2019
@rynowak rynowak mentioned this issue Mar 4, 2019
Closed
56 tasks
This was referenced Mar 29, 2019
Merged
Closed
pranavkm added a commit that referenced this issue Apr 1, 2019
@pranavkm
Use MessagePackReader \ MessagePackWriter to implement IHubProtocol f…
d86c9b3 
…or server-side Blazor (#8687)

* Use MessagePackReader \ MessagePackWriter to implement IHubProtocol for server-side Blazor

Fixes #7311
@pranavkm pranavkm added the Done This issue has been fixed label Apr 1, 2019
@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Components Big Rock This issue tracks a big effort which can span multiple issues Done This issue has been fixed External This is an issue in a component not contained in this repository. It is open for tracking purposes.
Projects
None yet
Milestone
3.0.0-preview4
Development

No branches or pull requests
6 participants
@pranavkm @SteveSandersonMS @rynowak @danroth27 @BrennanConroy @mkArtakMSFT