Set new HTTPS environment variable when using out of process #16713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
requested review from
halter73,
davidfowl,
Tratcher and
BrennanConroy
|
Scenario approved for 3.1.0-Preview3, assuming code reviews and CI are good before the cutoff. |
Tratcher
approved these changes
Oct 31, 2019
src/Servers/IIS/IIS/test/testassets/InProcessWebSite/Startup.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Oct 31, 2019
jkotalik
changed the title
|
@BrennanConroy TransportCommunicatesErrorToApplicationWhenClientDisconnectsAbnormally (SignalR test), known flaky? https://dev.azure.com/dnceng/public/_build/results?buildId=411560&view=ms.vss-test-web.build-test-results-tab&runId=12900532&resultId=105256&paneView=debug |
😢 no |
This was referenced Nov 6, 2019
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15243.
Today, ANCMV2 started setting the ASPNETCORE_HTTPS_PORT. This affected 2.2 applications that updated ANCMV2 to start always redirecting to HTTPS if the RedirectionMiddleware was enabled, as redirecting didn't work in 2.2 with ANCM.
This fix adds a new HTTPS_PORT environment variable called ANCM_HTTPS_PORT, which is now set by ANCM instead of HTTPS_PORT. The HttpsRedirectionMiddleware has also been updated to start reading this new value as a backup to the HTTPS_PORT. This means that if HTTPS_PORT is set, it will still always win over the ANCM port.
@BillHiebert this could affect IISExpress; when you set the HTTPS_PORT, do you set it to the HTTPS_PORT iisexpress is going to listen on? If so, then this change shouldn't break anything; the HTTPS_PORT still wins.
WIP because I still want to add another test with the HttpsRedirectionMiddleware.
@Pilchie for 3.1 approval