Skip to content

Use smaller test collections #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dougbu opened this issue Oct 26, 2017 · 2 comments
Closed

Use smaller test collections #95

dougbu opened this issue Oct 26, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@dougbu
Copy link
Contributor

dougbu commented Oct 26, 2017

The fix for #41 was intended to be temporary. It worked but had the cost of placing a large number of tests in the same collection, preventing parallel execution of the affected test classes.

Should revert f098836 and instead use [CollectionDefinition(DisableParallelization = true)] for either the original collection or a new collection containing DisplayExtensionsTest, EditorExtensionsTest and any other test class that writes to the ScopeStorage, ViewEngines.Engines or ModelMetadataProviders.Current static properties.

FYI:

  • DisableParallelization is a new feature of the xUnit 2.3.0 runtime. It ensures no other test collection (aka test class in most cases) runs in parallel with one using that CollectionDefinition.
  • f098836 affected only the System.Web.Mvc.Test test assembly but should check the other assemblies to see if DisableParallelization would help there too i.e. see if only a small subset of the test collections change static properties
  • no test assembly has more than one explicit test collection i.e. almost every test class runs in parallel with others
  • multiple test assemblies declare a "Uses ScopeStorage or ViewEngines.Engines" test collection but, due to the assembly boundaries, they aren't really the same
@dougbu dougbu added the task label Oct 26, 2017
@dougbu dougbu added this to the 3.2.6 milestone Apr 3, 2018
@dougbu
Copy link
Contributor Author

dougbu commented Apr 10, 2018

Moving to 3.2.5 and self-assigning since I'll do this as my first try on fixing #125. That is, #125 may be a duplicate of this issue.

@dougbu dougbu self-assigned this Apr 10, 2018
@dougbu dougbu modified the milestones: 3.2.6, 3.2.5 Apr 10, 2018
@danroth27 danroth27 modified the milestones: 3.2.5, 3.2.6 Apr 29, 2018
@dougbu dougbu modified the milestones: 3.2.6, 3.2.7 May 11, 2018
@dougbu dougbu modified the milestones: 3.2.7, 3.2.8 Nov 6, 2018
@mkArtakMSFT
Copy link

Closing as this is not needed and we don't release too often here to be concerned with the time it takes to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants