-
Notifications
You must be signed in to change notification settings - Fork 40
Detect if machine is 32-bit only in build.ps1 #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Edge case to consider: PowerShell can run in x86 mode on x64 machines ("PowerShell (x86)"). In this case, PROCESSOR_ARCHITEW6432 will be set to AMD64 and PROCESS_ARCHITECTURE will be x86. Should we use the true CPU arch or the shell arch in this case? |
Ah I didn't realize that PROCESS_ARCHITECTURE returned the current shell's architecture. We should probably base it off the true CPU's arch. |
A secondary concern here is that once our docker stuff is up and running we should test some things on 32-bit systems so that we know about this kind of bug. |
Has this come up again since this was opened? If not, I'm inclined to close this because the value seems very small. |
Let's close it for now, we can re-open it if/when we have specific cause to. |
Currently our build scripts fail on machines that are 32-bit only. Though this is rarely a blocker or issue for us, but external contributers may be using 32-bit machines (Ex aspnet/dependencyinjection). @natemcmaster mentioned we could check PROCESS_ARCHITECTURE to see if the machine is 32-bit or 64-bit.
The text was updated successfully, but these errors were encountered: