#274 Reorganize the strong header type extensions. Remove SendAsync extensions.

Author: Tratcher

src/Microsoft.AspNet.Http.Extensions/HeaderDictionaryTypeExtensions.cs

@@ -23,12 +23,14 @@ public static ResponseHeaders GetTypedHeaders(this HttpResponse response)
             return new ResponseHeaders(response.Headers);
         }
 
-        public static DateTimeOffset? GetDate([NotNull] this IHeaderDictionary headers, [NotNull] string name)
+        // These are all shared helpers used by both RequestHeaders and ResponseHeaders
+
+        internal static DateTimeOffset? GetDate([NotNull] this IHeaderDictionary headers, [NotNull] string name)
         {
             return headers.Get<DateTimeOffset?>(name);
         }
 
-        public static void Set([NotNull] this IHeaderDictionary headers, [NotNull] string name, object value)
+        internal static void Set([NotNull] this IHeaderDictionary headers, [NotNull] string name, object value)
         {
             if (value == null)
             {
@@ -40,7 +42,7 @@ public static void Set([NotNull] this IHeaderDictionary headers, [NotNull] strin
             }
         }
 
-        public static void SetList<T>([NotNull] this IHeaderDictionary headers, [NotNull] string name, IList<T> values)
+        internal static void SetList<T>([NotNull] this IHeaderDictionary headers, [NotNull] string name, IList<T> values)
         {
             if (values == null || values.Count == 0)
             {
@@ -52,7 +54,7 @@ public static void SetList<T>([NotNull] this IHeaderDictionary headers, [NotNull
             }
         }
 
-        public static void SetDate([NotNull] this IHeaderDictionary headers, [NotNull] string name, DateTimeOffset? value)
+        internal static void SetDate([NotNull] this IHeaderDictionary headers, [NotNull] string name, DateTimeOffset? value)
         {
             if (value.HasValue)
             {
@@ -64,16 +66,6 @@ public static void SetDate([NotNull] this IHeaderDictionary headers, [NotNull] s
             }
         }
 
-        public static void Append([NotNull] this IHeaderDictionary headers, [NotNull] string name, [NotNull] object value)
-        {
-            headers.Append(name, value.ToString());
-        }
-
-        public static void AppendList<T>([NotNull] this IHeaderDictionary headers, [NotNull] string name, [NotNull] IList<T> values)
-        {
-            headers.AppendValues(name, values.Select(value => value.ToString()).ToArray());
-        }
-
         private static IDictionary<Type, object> KnownParsers = new Dictionary<Type, object>()
         {
             { typeof(CacheControlHeaderValue), new Func<string, CacheControlHeaderValue>(value => { CacheControlHeaderValue result; return CacheControlHeaderValue.TryParse(value, out result) ? result : null; }) },
@@ -96,7 +88,7 @@ public static void AppendList<T>([NotNull] this IHeaderDictionary headers, [NotN
             { typeof(SetCookieHeaderValue), new Func<IList<string>, IList<SetCookieHeaderValue>>(value => { IList<SetCookieHeaderValue> result; return SetCookieHeaderValue.TryParseList(value, out result) ? result : null; })  },
         };
 
-        public static T Get<T>([NotNull] this IHeaderDictionary headers, string name)
+        internal static T Get<T>([NotNull] this IHeaderDictionary headers, string name)
         {
             object temp;
             if (KnownParsers.TryGetValue(typeof(T), out temp))
@@ -114,7 +106,7 @@ public static T Get<T>([NotNull] this IHeaderDictionary headers, string name)
             return GetViaReflection<T>(value);
         }
 
-        public static IList<T> GetList<T>([NotNull] this IHeaderDictionary headers, string name)
+        internal static IList<T> GetList<T>([NotNull] this IHeaderDictionary headers, string name)
         {
             object temp;
             if (KnownListParsers.TryGetValue(typeof(T), out temp))

src/Microsoft.AspNet.Http.Extensions/HttpResponseSendingExtensions.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using Microsoft.Framework.Internal;
 using Microsoft.Net.Http.Headers;
 
@@ -256,5 +257,35 @@ public RangeHeaderValue Range
                 Headers.Set(HeaderNames.Range, value);
             }
         }
+
+        public T Get<T>(string name)
+        {
+            return Headers.Get<T>(name);
+        }
+
+        public IList<T> GetList<T>(string name)
+        {
+            return Headers.GetList<T>(name);
+        }
+
+        public void Set([NotNull] string name, object value)
+        {
+            Headers.Set(name, value);
+        }
+
+        public void SetList<T>([NotNull] string name, IList<T> values)
+        {
+            Headers.SetList<T>(name, values);
+        }
+
+        public void Append([NotNull] string name, [NotNull] object value)
+        {
+            Headers.Append(name, value.ToString());
+        }
+
+        public void AppendList<T>([NotNull] string name, [NotNull] IList<T> values)
+        {
+            Headers.AppendValues(name, values.Select(value => value.ToString()).ToArray());
+        }
     }
 }

src/Microsoft.AspNet.Http.Extensions/RequestHeaders.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using Microsoft.AspNet.Http.Extensions;
 using Microsoft.Framework.Internal;
 using Microsoft.Net.Http.Headers;
@@ -153,5 +154,35 @@ public IList<SetCookieHeaderValue> SetCookie
                 Headers.SetList(HeaderNames.SetCookie, value);
             }
         }
+
+        public T Get<T>(string name)
+        {
+            return Headers.Get<T>(name);
+        }
+
+        public IList<T> GetList<T>(string name)
+        {
+            return Headers.GetList<T>(name);
+        }
+
+        public void Set([NotNull] string name, object value)
+        {
+            Headers.Set(name, value);
+        }
+
+        public void SetList<T>([NotNull] string name, IList<T> values)
+        {
+            Headers.SetList<T>(name, values);
+        }
+
+        public void Append([NotNull] string name, [NotNull] object value)
+        {
+            Headers.Append(name, value.ToString());
+        }
+
+        public void AppendList<T>([NotNull] string name, [NotNull] IList<T> values)
+        {
+            Headers.AppendValues(name, values.Select(value => value.ToString()).ToArray());
+        }
     }
 }