#542 Add IHttpConnectionFeature.ConnectionId

Author: Tratcher

src/Microsoft.AspNetCore.Http.Features/IHttpConnectionFeature.cs

@@ -5,11 +5,34 @@
 
 namespace Microsoft.AspNetCore.Http.Features
 {
+    /// <summary>
+    /// Information regarding the TCP/IP connection carrying the request.
+    /// </summary>
     public interface IHttpConnectionFeature
     {
+        /// <summary>
+        /// The unique identifier for the connection the request was received on. This is primarily for diagnostic purposes.
+        /// </summary>
+        string ConnectionId { get; set; }
+
+        /// <summary>
+        /// The IPAddress of the client making the request. Note this may be for a proxy rather than the end user.
+        /// </summary>
         IPAddress RemoteIpAddress { get; set; }
+
+        /// <summary>
+        /// The local IPAddress on which the request was received.
+        /// </summary>
         IPAddress LocalIpAddress { get; set; }
+
+        /// <summary>
+        /// The remote port of the client making the request.
+        /// </summary>
         int RemotePort { get; set; }
+
+        /// <summary>
+        /// The local port on which the request was received.
+        /// </summary>
         int LocalPort { get; set; }
     }
 }

src/Microsoft.AspNetCore.Http/Features/HttpConnectionFeature.cs

@@ -11,6 +11,8 @@ public HttpConnectionFeature()
         {
         }
 
+        public string ConnectionId { get; set; }
+
         public IPAddress LocalIpAddress { get; set; }
 
         public int LocalPort { get; set; }

src/Microsoft.AspNetCore.Owin/OwinConstants.cs

@@ -73,6 +73,7 @@ internal static class CommonKeys
             public const string RemotePort = "server.RemotePort";
             public const string LocalIpAddress = "server.LocalIpAddress";
             public const string LocalPort = "server.LocalPort";
+            public const string ConnectionId = "server.ConnectionId";
             public const string TraceOutput = "host.TraceOutput";
             public const string Addresses = "host.Addresses";
             public const string AppName = "host.AppName";

src/Microsoft.AspNetCore.Owin/OwinEnvironment.cs

@@ -74,6 +74,9 @@ public OwinEnvironment(HttpContext context)
                     }))
                 },
 
+                { OwinConstants.CommonKeys.ConnectionId, new FeatureMap<IHttpConnectionFeature>(feature => feature.ConnectionId,
+                    (feature, value) => feature.ConnectionId = Convert.ToString(value, CultureInfo.InvariantCulture)) },
+
                 { OwinConstants.CommonKeys.LocalPort, new FeatureMap<IHttpConnectionFeature>(feature => feature.LocalPort.ToString(CultureInfo.InvariantCulture),
                     (feature, value) => feature.LocalPort = Convert.ToInt32(value, CultureInfo.InvariantCulture)) },
                 { OwinConstants.CommonKeys.RemotePort, new FeatureMap<IHttpConnectionFeature>(feature => feature.RemotePort.ToString(CultureInfo.InvariantCulture),

src/Microsoft.AspNetCore.Owin/OwinFeatureCollection.cs

@@ -190,6 +190,12 @@ int IHttpConnectionFeature.LocalPort
             set { Prop(OwinConstants.CommonKeys.LocalPort, value.ToString(CultureInfo.InvariantCulture)); }
         }
 
+        string IHttpConnectionFeature.ConnectionId
+        {
+            get { return Prop<string>(OwinConstants.CommonKeys.ConnectionId); }
+            set { Prop(OwinConstants.CommonKeys.ConnectionId, value); }
+        }
+
         private bool SupportsSendFile
         {
             get