Remove cached Response from DefaultAuthenticationManager

benaadams · benaadams · commit 67cc6bfe07fa · 2015-12-07T19:17:07.000Z
diff --git a/src/Microsoft.AspNet.Http/Authentication/DefaultAuthenticationManager.cs b/src/Microsoft.AspNet.Http/Authentication/DefaultAuthenticationManager.cs
@@ -18,7 +18,6 @@ public class DefaultAuthenticationManager : AuthenticationManager, IFeatureCache
         private int _cachedFeaturesRevision = -1;
 
         private IHttpAuthenticationFeature _authentication;
-        private IHttpResponseFeature _response;
 
         public DefaultAuthenticationManager(IFeatureCollection features)
         {
@@ -42,7 +41,6 @@ public void UpdateFeatures(IFeatureCollection features)
         private void ResetFeatures()
         {
             _authentication = null;
-            _response = null;
             _cachedFeaturesRevision = _features.Revision;
         }
 
@@ -58,11 +56,6 @@ private IHttpAuthenticationFeature HttpAuthenticationFeature
             }
         }
 
-        private IHttpResponseFeature HttpResponseFeature
-        {
-            get { return FeatureHelpers.GetAndCache(this, _features, ref _response); }
-        }
-
         public override IEnumerable<AuthenticationDescription> GetAuthenticationSchemes()
         {
             var handler = HttpAuthenticationFeature.Handler;

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ public class DefaultAuthenticationManager : AuthenticationManager, IFeatureCache`
`18`	`18`	`private int _cachedFeaturesRevision = -1;`
`19`	`19`
`20`	`20`	`private IHttpAuthenticationFeature _authentication;`
`21`		`- private IHttpResponseFeature _response;`
`22`	`21`
`23`	`22`	`public DefaultAuthenticationManager(IFeatureCollection features)`
`24`	`23`	`{`
`@@ -42,7 +41,6 @@ public void UpdateFeatures(IFeatureCollection features)`
`42`	`41`	`private void ResetFeatures()`
`43`	`42`	`{`
`44`	`43`	`_authentication = null;`
`45`		`- _response = null;`
`46`	`44`	`_cachedFeaturesRevision = _features.Revision;`
`47`	`45`	`}`
`48`	`46`
`@@ -58,11 +56,6 @@ private IHttpAuthenticationFeature HttpAuthenticationFeature`
`58`	`56`	`}`
`59`	`57`	`}`
`60`	`58`
`61`		`- private IHttpResponseFeature HttpResponseFeature`
`62`		`- {`
`63`		`- get { return FeatureHelpers.GetAndCache(this, _features, ref _response); }`
`64`		`- }`
`65`		`-`
`66`	`59`	`public override IEnumerable<AuthenticationDescription> GetAuthenticationSchemes()`
`67`	`60`	`{`
`68`	`61`	`var handler = HttpAuthenticationFeature.Handler;`