Reduce the amount of argument checking by flattening the call graph. (#995)

Author: davidfowl

src/Microsoft.AspNetCore.Http.Extensions/SendFileResponseExtensions.cs

@@ -22,8 +22,7 @@ public static class SendFileResponseExtensions
         /// <param name="response"></param>
         /// <param name="file">The file.</param>
         /// <param name="cancellationToken">The <see cref="CancellationToken"/>.</param>
-        public static Task SendFileAsync(this HttpResponse response, IFileInfo file,
-            CancellationToken cancellationToken = default(CancellationToken))
+        public static Task SendFileAsync(this HttpResponse response, IFileInfo file, CancellationToken cancellationToken = default)
         {
             if (response == null)
             {
@@ -34,7 +33,7 @@ public static Task SendFileAsync(this HttpResponse response, IFileInfo file,
                 throw new ArgumentNullException(nameof(file));
             }
 
-            return response.SendFileAsync(file, 0, null, cancellationToken);
+            return SendFileAsyncCore(response, file, 0, null, cancellationToken);
         }
 
         /// <summary>
@@ -46,8 +45,7 @@ public static Task SendFileAsync(this HttpResponse response, IFileInfo file,
         /// <param name="count">The number of bytes to send, or null to send the remainder of the file.</param>
         /// <param name="cancellationToken"></param>
         /// <returns></returns>
-        public static async Task SendFileAsync(this HttpResponse response, IFileInfo file, long offset, long? count,
-            CancellationToken cancellationToken = default(CancellationToken))
+        public static Task SendFileAsync(this HttpResponse response, IFileInfo file, long offset, long? count, CancellationToken cancellationToken = default)
         {
             if (response == null)
             {
@@ -57,23 +55,8 @@ public static async Task SendFileAsync(this HttpResponse response, IFileInfo fil
             {
                 throw new ArgumentNullException(nameof(file));
             }
-            CheckRange(offset, count, file.Length);
 
-            if (string.IsNullOrEmpty(file.PhysicalPath))
-            {
-                using (var fileContent = file.CreateReadStream())
-                {
-                    if (offset > 0)
-                    {
-                        fileContent.Seek(offset, SeekOrigin.Begin);
-                    }
-                    await StreamCopyOperation.CopyToAsync(fileContent, response.Body, count, cancellationToken);
-                }
-            }
-            else
-            {
-                await response.SendFileAsync(file.PhysicalPath, offset, count, cancellationToken);
-            }
+            return SendFileAsyncCore(response, file, offset, count, cancellationToken);
         }
 
         /// <summary>
@@ -83,8 +66,7 @@ public static async Task SendFileAsync(this HttpResponse response, IFileInfo fil
         /// <param name="fileName">The full path to the file.</param>
         /// <param name="cancellationToken">The <see cref="CancellationToken"/>.</param>
         /// <returns></returns>
-        public static Task SendFileAsync(this HttpResponse response, string fileName,
-            CancellationToken cancellationToken = default(CancellationToken))
+        public static Task SendFileAsync(this HttpResponse response, string fileName, CancellationToken cancellationToken = default)
         {
             if (response == null)
             {
@@ -96,7 +78,7 @@ public static Task SendFileAsync(this HttpResponse response, string fileName,
                 throw new ArgumentNullException(nameof(fileName));
             }
 
-            return response.SendFileAsync(fileName, 0, null, cancellationToken);
+            return SendFileAsyncCore(response, fileName, 0, null, cancellationToken);
         }
 
         /// <summary>
@@ -108,8 +90,7 @@ public static Task SendFileAsync(this HttpResponse response, string fileName,
         /// <param name="count">The number of bytes to send, or null to send the remainder of the file.</param>
         /// <param name="cancellationToken"></param>
         /// <returns></returns>
-        public static Task SendFileAsync(this HttpResponse response, string fileName, long offset, long? count,
-            CancellationToken cancellationToken = default(CancellationToken))
+        public static Task SendFileAsync(this HttpResponse response, string fileName, long offset, long? count, CancellationToken cancellationToken = default)
         {
             if (response == null)
             {
@@ -121,26 +102,50 @@ public static Task SendFileAsync(this HttpResponse response, string fileName, lo
                 throw new ArgumentNullException(nameof(fileName));
             }
 
+            return SendFileAsyncCore(response, fileName, offset, count, cancellationToken);
+        }
+
+        private static async Task SendFileAsyncCore(HttpResponse response, IFileInfo file, long offset, long? count, CancellationToken cancellationToken)
+        {
+            if (string.IsNullOrEmpty(file.PhysicalPath))
+            {
+                CheckRange(offset, count, file.Length);
+
+                using (var fileContent = file.CreateReadStream())
+                {
+                    if (offset > 0)
+                    {
+                        fileContent.Seek(offset, SeekOrigin.Begin);
+                    }
+                    await StreamCopyOperation.CopyToAsync(fileContent, response.Body, count, cancellationToken);
+                }
+            }
+            else
+            {
+                await response.SendFileAsync(file.PhysicalPath, offset, count, cancellationToken);
+            }
+        }
+
+        private static Task SendFileAsyncCore(HttpResponse response, string fileName, long offset, long? count, CancellationToken cancellationToken = default)
+        {
             var sendFile = response.HttpContext.Features.Get<IHttpSendFileFeature>();
             if (sendFile == null)
             {
-                return SendFileAsync(response.Body, fileName, offset, count, cancellationToken);
+                return SendFileAsyncCore(response.Body, fileName, offset, count, cancellationToken);
             }
 
             return sendFile.SendFileAsync(fileName, offset, count, cancellationToken);
         }
 
         // Not safe for overlapped writes.
-        private static async Task SendFileAsync(Stream outputStream, string fileName, long offset, long? count,
-            CancellationToken cancel = default(CancellationToken))
+        private static async Task SendFileAsyncCore(Stream outputStream, string fileName, long offset, long? count, CancellationToken cancel = default)
         {
             cancel.ThrowIfCancellationRequested();
 
             var fileInfo = new FileInfo(fileName);
             CheckRange(offset, count, fileInfo.Length);
 
             int bufferSize = 1024 * 16;
-
             var fileStream = new FileStream(
                 fileName,
                 FileMode.Open,
@@ -151,7 +156,11 @@ private static async Task SendFileAsync(Stream outputStream, string fileName, lo
 
             using (fileStream)
             {
-                fileStream.Seek(offset, SeekOrigin.Begin);
+                if (offset > 0)
+                {
+                    fileStream.Seek(offset, SeekOrigin.Begin);
+                }
+
                 await StreamCopyOperation.CopyToAsync(fileStream, outputStream, count, cancel);
             }
         }