Remove unused parameter in ctor of HttpContextFactory (#881)

- We removed the use of the ObjectPoolProvider in 1.x, this change
just removes it from the ctor.

Author: davidfowl

src/Microsoft.AspNetCore.Http/HttpContextFactory.cs

@@ -3,7 +3,6 @@
 
 using System;
 using Microsoft.AspNetCore.Http.Features;
-using Microsoft.Extensions.ObjectPool;
 using Microsoft.Extensions.Options;
 
 namespace Microsoft.AspNetCore.Http
@@ -13,17 +12,13 @@ public class HttpContextFactory : IHttpContextFactory
         private readonly IHttpContextAccessor _httpContextAccessor;
         private readonly FormOptions _formOptions;
 
-        public HttpContextFactory(ObjectPoolProvider poolProvider, IOptions<FormOptions> formOptions)
-            : this(poolProvider, formOptions, httpContextAccessor: null)
+        public HttpContextFactory(IOptions<FormOptions> formOptions)
+            : this(formOptions, httpContextAccessor: null)
         {
         }
 
-        public HttpContextFactory(ObjectPoolProvider poolProvider, IOptions<FormOptions> formOptions, IHttpContextAccessor httpContextAccessor)
+        public HttpContextFactory(IOptions<FormOptions> formOptions, IHttpContextAccessor httpContextAccessor)
         {
-            if (poolProvider == null)
-            {
-                throw new ArgumentNullException(nameof(poolProvider));
-            }
             if (formOptions == null)
             {
                 throw new ArgumentNullException(nameof(formOptions));

src/Microsoft.AspNetCore.Http/breakingchanges.netcore.json

@@ -0,0 +1,12 @@
+  [
+    {
+      "TypeId": "public class Microsoft.AspNetCore.Http.HttpContextFactory : Microsoft.AspNetCore.Http.IHttpContextFactory",
+      "MemberId": "public .ctor(Microsoft.Extensions.ObjectPool.ObjectPoolProvider poolProvider, Microsoft.Extensions.Options.IOptions<Microsoft.AspNetCore.Http.Features.FormOptions> formOptions)",
+      "Kind": "Removal"
+    },
+    {
+      "TypeId": "public class Microsoft.AspNetCore.Http.HttpContextFactory : Microsoft.AspNetCore.Http.IHttpContextFactory",
+      "MemberId": "public .ctor(Microsoft.Extensions.ObjectPool.ObjectPoolProvider poolProvider, Microsoft.Extensions.Options.IOptions<Microsoft.AspNetCore.Http.Features.FormOptions> formOptions, Microsoft.AspNetCore.Http.IHttpContextAccessor httpContextAccessor)",
+      "Kind": "Removal"
+    }
+  ]

test/Microsoft.AspNetCore.Http.Tests/HttpContextFactoryTests.cs

@@ -4,7 +4,6 @@
 using System;
 using System.IO;
 using Microsoft.AspNetCore.Http.Features;
-using Microsoft.Extensions.ObjectPool;
 using Microsoft.Extensions.Options;
 using Xunit;
 
@@ -17,7 +16,7 @@ public void CreateHttpContextSetsHttpContextAccessor()
         {
             // Arrange
             var accessor = new HttpContextAccessor();
-            var contextFactory = new HttpContextFactory(new DefaultObjectPoolProvider(), Options.Create(new FormOptions()), accessor);
+            var contextFactory = new HttpContextFactory(Options.Create(new FormOptions()), accessor);
 
             // Act
             var context = contextFactory.Create(new FeatureCollection());
@@ -30,7 +29,7 @@ public void CreateHttpContextSetsHttpContextAccessor()
         public void AllowsCreatingContextWithoutSettingAccessor()
         {
             // Arrange
-            var contextFactory = new HttpContextFactory(new DefaultObjectPoolProvider(), Options.Create(new FormOptions()));
+            var contextFactory = new HttpContextFactory(Options.Create(new FormOptions()));
 
             // Act & Assert
             var context = contextFactory.Create(new FeatureCollection());