Reduce FeatureReference checking, lazy init FormFeature

Author: benaadams

src/Microsoft.AspNetCore.Http.Features/FeatureReferences.cs

@@ -15,6 +15,13 @@ public FeatureReferences(IFeatureCollection collection)
             Revision = collection.Revision;
         }
 
+        public FeatureReferences(IFeatureCollection collection, int revision)
+        {
+            Collection = collection;
+            Cache = default(TCache);
+            Revision = revision;
+        }
+
         public IFeatureCollection Collection { get; private set; }
         public int Revision { get; private set; }
 

src/Microsoft.AspNetCore.Http/DefaultHttpContext.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Runtime.CompilerServices;
 using System.Security.Claims;
 using System.Threading;
 using Microsoft.AspNetCore.Http.Authentication;
@@ -24,6 +25,7 @@ public class DefaultHttpContext : HttpContext
         private readonly static Func<IFeatureCollection, ISessionFeature> _nullSessionFeature = f => null;
         private readonly static Func<IFeatureCollection, IHttpRequestIdentifierFeature> _newHttpRequestIdentifierFeature = f => new HttpRequestIdentifierFeature();
 
+        private FormOptions _formOptions;
         private FeatureReferences<FeatureInterfaces> _features;
 
         private HttpRequest _request;
@@ -44,15 +46,26 @@ public DefaultHttpContext()
         }
 
         public DefaultHttpContext(IFeatureCollection features)
+            : this(features, FormOptions.Default)
         {
-            Initialize(features);
         }
 
-        public virtual void Initialize(IFeatureCollection features)
+        public DefaultHttpContext(IFeatureCollection features, FormOptions formOptions)
+        {
+            Initialize(features, formOptions);
+        }
+
+        public virtual void Initialize(IFeatureCollection features, FormOptions formOptions)
         {
             _features = new FeatureReferences<FeatureInterfaces>(features);
             _request = InitializeHttpRequest();
             _response = InitializeHttpResponse();
+            _formOptions = formOptions;
+        }
+
+        public virtual void Initialize(IFeatureCollection features)
+        {
+            Initialize(features, FormOptions.Default);
         }
 
         public virtual void Uninitialize()
@@ -85,6 +98,7 @@ public virtual void Uninitialize()
                 UninitializeWebSocketManager(_websockets);
                 _websockets = null;
             }
+            _formOptions = null;
         }
 
         private IItemsFeature ItemsFeature =>
@@ -185,18 +199,43 @@ public override ISession Session
             }
         }
 
-
-
         public override void Abort()
         {
             LifetimeFeature.Abort();
         }
 
+        [MethodImpl(MethodImplOptions.NoInlining)]
+        private void InitializeRequestResponse()
+        {
+            var revision = _features.Revision;
+            var collection = _features.Collection;
+
+            _request = new DefaultHttpRequest(this, revision, collection, _formOptions);
+            _response = new DefaultHttpResponse(this, revision, collection);
+        }
+
+        protected virtual HttpRequest InitializeHttpRequest()
+        {
+            if (_request == null)
+            {
+                InitializeRequestResponse();
+            }
+
+            return _request;
+        }
 
-        protected virtual HttpRequest InitializeHttpRequest() => new DefaultHttpRequest(this);
         protected virtual void UninitializeHttpRequest(HttpRequest instance) { }
 
-        protected virtual HttpResponse InitializeHttpResponse() => new DefaultHttpResponse(this);
+        protected virtual HttpResponse InitializeHttpResponse()
+        {
+            if (_response == null)
+            {
+                InitializeRequestResponse();
+            }
+
+            return _response;
+        }
+
         protected virtual void UninitializeHttpResponse(HttpResponse instance) { }
 
         protected virtual ConnectionInfo InitializeConnectionInfo() => new DefaultConnectionInfo(Features);

src/Microsoft.AspNetCore.Http/Features/FormFeature.cs

@@ -15,8 +15,6 @@ namespace Microsoft.AspNetCore.Http.Features
 {
     public class FormFeature : IFormFeature
     {
-        private static readonly FormOptions DefaultFormOptions = new FormOptions();
-
         private readonly HttpRequest _request;
         private readonly FormOptions _options;
         private Task<IFormCollection> _parsedFormTask;
@@ -32,7 +30,7 @@ public FormFeature(IFormCollection form)
             Form = form;
         }
         public FormFeature(HttpRequest request)
-            : this(request, DefaultFormOptions)
+            : this(request, FormOptions.Default)
         {
         }
 

src/Microsoft.AspNetCore.Http/Features/FormOptions.cs

@@ -8,6 +8,8 @@ namespace Microsoft.AspNetCore.Http.Features
 {
     public class FormOptions
     {
+        public static readonly FormOptions Default = new FormOptions();
+
         public const int DefaultMemoryBufferThreshold = 1024 * 64;
         public const int DefaultBufferBodyLengthLimit = 1024 * 1024 * 128;
         public const int DefaultMultipartBoundaryLengthLimit = 128;

src/Microsoft.AspNetCore.Http/HttpContextFactory.cs

@@ -24,7 +24,7 @@ public HttpContextFactory(IOptions<FormOptions> formOptions, IHttpContextAccesso
                 throw new ArgumentNullException(nameof(formOptions));
             }
 
-            _formOptions = formOptions.Value;
+            _formOptions = formOptions.Value ?? FormOptions.Default;
             _httpContextAccessor = httpContextAccessor;
         }
 
@@ -35,15 +35,12 @@ public HttpContext Create(IFeatureCollection featureCollection)
                 throw new ArgumentNullException(nameof(featureCollection));
             }
 
-            var httpContext = new DefaultHttpContext(featureCollection);
+            var httpContext = new DefaultHttpContext(featureCollection, _formOptions);
             if (_httpContextAccessor != null)
             {
                 _httpContextAccessor.HttpContext = httpContext;
             }
 
-            var formFeature = new FormFeature(httpContext.Request, _formOptions);
-            featureCollection.Set<IFormFeature>(formFeature);
-
             return httpContext;
         }
 

src/Microsoft.AspNetCore.Http/Internal/DefaultHttpRequest.cs

@@ -15,26 +15,39 @@ public class DefaultHttpRequest : HttpRequest
         // Lambdas hoisted to static readonly fields to improve inlining https://github.com/dotnet/roslyn/issues/13624
         private readonly static Func<IFeatureCollection, IHttpRequestFeature> _nullRequestFeature = f => null;
         private readonly static Func<IFeatureCollection, IQueryFeature> _newQueryFeature = f => new QueryFeature(f);
-        private readonly static Func<HttpRequest, IFormFeature> _newFormFeature = r => new FormFeature(r);
+        private readonly static Func<(HttpRequest request, FormOptions options), IFormFeature> _newFormFeature = (r) => new FormFeature(r.request, r.options ?? FormOptions.Default);
         private readonly static Func<IFeatureCollection, IRequestCookiesFeature> _newRequestCookiesFeature = f => new RequestCookiesFeature(f);
 
+        private FormOptions _formOptions;
         private HttpContext _context;
         private FeatureReferences<FeatureInterfaces> _features;
 
         public DefaultHttpRequest(HttpContext context)
+            : this (context, context.Features.Revision, context.Features, FormOptions.Default)
         {
-            Initialize(context);
         }
 
-        public virtual void Initialize(HttpContext context)
+        internal DefaultHttpRequest(HttpContext context, int revision, IFeatureCollection features, FormOptions formOptions)
         {
             _context = context;
-            _features = new FeatureReferences<FeatureInterfaces>(context.Features);
+            Initialize(features, revision, formOptions);
+        }
+
+        public virtual void Initialize(HttpContext context)
+        {
+            Initialize(context.Features, context.Features.Revision, FormOptions.Default);
+        }
+
+        private void Initialize(IFeatureCollection features, int revision, FormOptions formOptions)
+        {
+            _features = new FeatureReferences<FeatureInterfaces>(features, revision);
+            _formOptions = formOptions;
         }
 
         public virtual void Uninitialize()
         {
             _context = null;
+            _formOptions = null;
             _features = default(FeatureReferences<FeatureInterfaces>);
         }
 
@@ -47,7 +60,7 @@ public virtual void Uninitialize()
             _features.Fetch(ref _features.Cache.Query, _newQueryFeature);
 
         private IFormFeature FormFeature =>
-            _features.Fetch(ref _features.Cache.Form, this, _newFormFeature);
+            _features.Fetch(ref _features.Cache.Form, (this, _formOptions), _newFormFeature);
 
         private IRequestCookiesFeature RequestCookiesFeature =>
             _features.Fetch(ref _features.Cache.Cookies, _newRequestCookiesFeature);

src/Microsoft.AspNetCore.Http/Internal/DefaultHttpResponse.cs

@@ -19,14 +19,25 @@ public class DefaultHttpResponse : HttpResponse
         private FeatureReferences<FeatureInterfaces> _features;
 
         public DefaultHttpResponse(HttpContext context)
+            : this(context, context.Features.Revision, context.Features)
         {
-            Initialize(context);
+        }
+
+        internal DefaultHttpResponse(HttpContext context, int revision, IFeatureCollection features)
+        {
+            _context = context;
+            Initialize(features, revision);
         }
 
         public virtual void Initialize(HttpContext context)
         {
             _context = context;
-            _features = new FeatureReferences<FeatureInterfaces>(context.Features);
+            Initialize(context.Features, context.Features.Revision);
+        }
+
+        private void Initialize(IFeatureCollection features, int revision)
+        {
+            _features = new FeatureReferences<FeatureInterfaces>(features, revision);
         }
 
         public virtual void Uninitialize()

test/Microsoft.AspNetCore.Http.Tests/DefaultHttpContextTests.cs

@@ -159,6 +159,8 @@ public void UpdateFeatures_ClearsCachedFeatures()
 
             // featurecollection is set. all cached interfaces are null.
             var context = new DefaultHttpContext(features);
+            // Trigger initalization
+            Assert.NotNull(context.Request);
             TestAllCachedFeaturesAreNull(context, features);
             Assert.Equal(3, features.Count());
 
@@ -178,7 +180,9 @@ public void UpdateFeatures_ClearsCachedFeatures()
             newFeatures.Set<IHttpWebSocketFeature>(new TestHttpWebSocketFeature());
 
             // featurecollection is set to newFeatures. all cached interfaces are null.
-            context.Initialize(newFeatures);
+            context.Initialize(newFeatures, FormOptions.Default);
+            // Trigger initalization
+            Assert.NotNull(context.Request);
             TestAllCachedFeaturesAreNull(context, newFeatures);
             Assert.Equal(3, newFeatures.Count());