Should StringValues implement Equals?

[Tratcher]

StringValues does not currently implement Equals (or GetHashCode). MVC implements their own wrapper that has Equals. If so, what should be considered equal?
"string" == new[] { "string" }?
string.Empty == null?
null == new[] { null }?
"value1,value2" == new[] { "value1", "value2" }?
Ordinal?

[atifaziz]

Since StringValues is logically just an array of strings with some internal optimizations, its equality and hashing should behave like that of an array when being checked for structural equality. That would provide the least surprises and yet still permit some customization when needed (e.g. ignore case when comparing each element).

[glennc]

@Tratcher can you round up @lodejard and @davidfowl to get an answer for this now-ish?

[davidfowl]

@rynowak we did this right?

[khellang]

@davidfowl dotnet/extensions@3533334

[rynowak]

@davidfowl - it implements .Equals. We should think about removing some of the overloaded == operators. Right now if you try to compare with null you get an error about ambiguity when you should get the 'Hey, it's a struct buddy' error.

[aspnet-hello]

This issue was moved to dotnet/aspnetcore#2726