You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 20, 2018. It is now read-only.
. We should find a creative way to avoid doing this so eagerly in the common cases. Here are some options:
Invent a new way to pass things to features lazily (hard, we tried this and ended up with crazy things)
Only new up the FormOptions if they were overridden. We'd need a way to detect if the FormOptions were actually set. This is doable but could get ugly as there's no way to detect if options were configured. /cc @HaoK
Only set the FormFeature if the request is a POST and HasFormContentType. Gross, but would be more pay for play than what we have today.
Today, in order to pass the form options to the
FormFeature
, we eagerly allocate it hereHttpAbstractions/src/Microsoft.AspNetCore.Http/HttpContextFactory.cs
Line 49 in 163836f
FormOptions
if they were overridden. We'd need a way to detect if theFormOptions
were actually set. This is doable but could get ugly as there's no way to detect if options were configured. /cc @HaoKFormFeature
if the request is a POST andHasFormContentType
. Gross, but would be more pay for play than what we have today./cc @vancem @Tratcher
The text was updated successfully, but these errors were encountered: