log exceptions

ajaybhargavb · ajaybhargavb · commit 255d5c22d5bb · 2015-03-10T15:02:07.000-07:00
diff --git a/src/Microsoft.Net.Http.Server/RequestProcessing/Response.cs b/src/Microsoft.Net.Http.Server/RequestProcessing/Response.cs
@@ -875,9 +875,9 @@ private void NotifyOnResponseCompleted()
                 {
                     actionPair.Item1(actionPair.Item2);
                 }
-                catch
+                catch (Exception ex)
                 {
-                    // Ignore exceptions
+                    RequestContext.Logger.LogWarning(Resources.Warning_ExceptionInOnResponseCompletedAction, ex);
                 }
             }
         }
diff --git a/src/Microsoft.Net.Http.Server/Resources.Designer.cs b/src/Microsoft.Net.Http.Server/Resources.Designer.cs
diff --git a/src/Microsoft.Net.Http.Server/Resources.resx b/src/Microsoft.Net.Http.Server/Resources.resx
@@ -147,4 +147,7 @@
   <data name="Exception_WrongIAsyncResult" xml:space="preserve">
     <value>The given IAsyncResult does not match this opperation.</value>
   </data>
+  <data name="Warning_ExceptionInOnResponseCompletedAction" xml:space="preserve">
+    <value>Exception occured in a registered response completed action.</value>
+  </data>
 </root>

Original file line number	Diff line number	Diff line change
`@@ -875,9 +875,9 @@ private void NotifyOnResponseCompleted()`
`875`	`875`	`{`
`876`	`876`	`actionPair.Item1(actionPair.Item2);`
`877`	`877`	`}`
`878`		`- catch`
	`878`	`+ catch (Exception ex)`
`879`	`879`	`{`
`880`		`- // Ignore exceptions`
	`880`	`+ RequestContext.Logger.LogWarning(Resources.Warning_ExceptionInOnResponseCompletedAction, ex);`
`881`	`881`	`}`
`882`	`882`	`}`
`883`	`883`	`}`